[GitHub] [tvm] NicolaLancellotti commented on a change in pull request #9589: [microNPU] Add support for TFLite concatenate

[GitBox <gi...@apache.org>]

NicolaLancellotti commented on a change in pull request #9589:
URL: https://github.com/apache/tvm/pull/9589#discussion_r757435110



##########
File path: python/tvm/relay/backend/contrib/ethosu/tir/transform.py
##########
@@ -58,4 +58,5 @@ def get_copy_params(stmt, producers, consumers):
         ),
         write_store.buffer_var,
         None,
+        True,

Review comment:
       The docstring for the last two return values is missing.

##########
File path: python/tvm/relay/backend/contrib/ethosu/tir/unary_elementwise.py
##########
@@ -71,4 +71,5 @@ def get_unary_elementwise_params(stmt, producers, consumers):
         ),
         output_pointer,
         replace_pointer,
+        is_allocator,

Review comment:
       ```is_allocator``` is missing in the docstring.

##########
File path: python/tvm/relay/backend/contrib/ethosu/tir/pooling.py
##########
@@ -88,4 +88,5 @@ def get_pooling_params(
         ),
         output_pointer,
         replace_pointer,
+        is_allocator,

Review comment:
       ```is_allocator``` is missing in the docstring.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org