Looking for testing on the Struts upgrade

[Brett Porter <br...@apache.org>]

I've merged the CONTINUUM-2713 branch back into trunk, which has upgraded Struts to the latest version. This had some significant changes in the tags used (as you can see in the commit [1]), though it should have no user-visible changes.

It would be good to get a couple of people to build trunk and test it, and report any regressions. Who can help with that?

If nothing major is found, we should move forward to releasing it.

Thanks,
Brett

[1] http://svn.apache.org/viewvc?limit_changes=0&view=revision&revision=1596252

Re: Looking for testing on the Struts upgrade

[Brett Porter <br...@apache.org>]

I did as much testing as I could, and I've gone ahead and pulled a release together - will put a vote out now. We can always roll again if any blockers are found.

Thanks,
Brett

On 23 May 2014, at 12:21 pm, Brett Porter <br...@apache.org> wrote:

> 
> 
> On 23 May 2014, at 12:21 am, Brent Atkinson <br...@gmail.com> wrote:
> 
>> I have had challenges verifying using the web tests. It seems the tests are
>> not repeatable unless I rebuild the whole project. I recall that there were
>> some commits to ensure repeatable tests. Should I expect running clean
>> install in the continuum-webapp-test directory multiple times will give the
>> same result without a clean build?
> 
> When you say clean build, you mean rebuilding the other modules? Yes, that should never be needed unless you make changes. If you run mvn clean install in the webapp-test directory, that will wipe out the whole installation and start over from the last built war, so there should be no reproducibility issues due to existing data (though there might be some due to general flakiness).
> 
> The reproducibility commits where so that tests could be run repeatedly from the IDE without cleaning the target directory or restarting the test server.
> 
> That said, the testing I think would be most interesting at the moment are the things the webapp tests don't cover - like pages where formatting doesn't look right. The Struts upgrade changed some of the HTML tags they rendered.
> 
> - Brett
> 

Re: Looking for testing on the Struts upgrade

[Brett Porter <br...@apache.org>]

On 23 May 2014, at 12:21 am, Brent Atkinson <br...@gmail.com> wrote:

> I have had challenges verifying using the web tests. It seems the tests are
> not repeatable unless I rebuild the whole project. I recall that there were
> some commits to ensure repeatable tests. Should I expect running clean
> install in the continuum-webapp-test directory multiple times will give the
> same result without a clean build?

When you say clean build, you mean rebuilding the other modules? Yes, that should never be needed unless you make changes. If you run mvn clean install in the webapp-test directory, that will wipe out the whole installation and start over from the last built war, so there should be no reproducibility issues due to existing data (though there might be some due to general flakiness).

The reproducibility commits where so that tests could be run repeatedly from the IDE without cleaning the target directory or restarting the test server.

That said, the testing I think would be most interesting at the moment are the things the webapp tests don't cover - like pages where formatting doesn't look right. The Struts upgrade changed some of the HTML tags they rendered.

- Brett

Re: Looking for testing on the Struts upgrade

[Brent Atkinson <br...@gmail.com>]

I have had challenges verifying using the web tests. It seems the tests are
not repeatable unless I rebuild the whole project. I recall that there were
some commits to ensure repeatable tests. Should I expect running clean
install in the continuum-webapp-test directory multiple times will give the
same result without a clean build?

Brent


On Tue, May 20, 2014 at 11:19 AM, Brett Porter <br...@apache.org> wrote:

>
> On 21 May 2014, at 12:46 am, Brent Atkinson <br...@gmail.com>
> wrote:
>
> > Brett,
> >
> > Thank you. I have cycles to test it. Recommendations on approach for
> > verifying outside of building and running web tests? I will start
> > immediately.
> >
>
> The web tests should be ok, in this case the best thing is to play with it
> ad-hoc, particularly if you have your own data or typical operations, to
> see if there is anything not working not covered by the tests. Also, check
> for bad layout, which the web tests won't pick up.
>
> - Brett
>
>

Re: Looking for testing on the Struts upgrade

[Brett Porter <br...@apache.org>]

On 21 May 2014, at 12:46 am, Brent Atkinson <br...@gmail.com> wrote:

> Brett,
> 
> Thank you. I have cycles to test it. Recommendations on approach for
> verifying outside of building and running web tests? I will start
> immediately.
> 

The web tests should be ok, in this case the best thing is to play with it ad-hoc, particularly if you have your own data or typical operations, to see if there is anything not working not covered by the tests. Also, check for bad layout, which the web tests won't pick up.

- Brett

Re: Looking for testing on the Struts upgrade

[Brent Atkinson <br...@gmail.com>]

Brett,

Thank you. I have cycles to test it. Recommendations on approach for
verifying outside of building and running web tests? I will start
immediately.

Brent


On Tue, May 20, 2014 at 10:21 AM, Brett Porter <br...@apache.org> wrote:

> I've merged the CONTINUUM-2713 branch back into trunk, which has upgraded
> Struts to the latest version. This had some significant changes in the tags
> used (as you can see in the commit [1]), though it should have no
> user-visible changes.
>
> It would be good to get a couple of people to build trunk and test it, and
> report any regressions. Who can help with that?
>
> If nothing major is found, we should move forward to releasing it.
>
> Thanks,
> Brett
>
> [1]
> http://svn.apache.org/viewvc?limit_changes=0&view=revision&revision=1596252