You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by ro...@apache.org on 2020/12/29 13:44:39 UTC

[buildstream] 03/03: element.py: Only update the source state after fetching

This is an automated email from the ASF dual-hosted git repository.

root pushed a commit to branch jonathan/skip_schedule_attempt
in repository https://gitbox.apache.org/repos/asf/buildstream.git

commit 0f67660712546d5ace11600a6f211b2f7014e002
Author: Jonathan Maw <jo...@codethink.co.uk>
AuthorDate: Wed Mar 27 17:01:28 2019 +0000

    element.py: Only update the source state after fetching
---
 buildstream/element.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/buildstream/element.py b/buildstream/element.py
index d9dddd2..d72ff61 100644
--- a/buildstream/element.py
+++ b/buildstream/element.py
@@ -1791,9 +1791,9 @@ class Element(Plugin):
     # Indicates that fetching the sources for this element has been done.
     #
     def _fetch_done(self):
-        # We are not updating the state recursively here since fetching can
-        # never end up in updating them.
-        self._update_state()
+        # After a fetch, the only change is that a source goes from RESOLVED
+        # to CACHED, which does not affect the element's cache key.
+        self.__update_source_state()
 
     # _pull_pending()
     #