You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2016/08/02 20:17:20 UTC

[jira] [Commented] (MPLUGIN-305) MojoAnnotationsScanner should have better control over dependency scanning

    [ https://issues.apache.org/jira/browse/MPLUGIN-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15404703#comment-15404703 ] 

Hudson commented on MPLUGIN-305:
--------------------------------

FAILURE: Integrated in maven-plugin-tools #256 (See [https://builds.apache.org/job/maven-plugin-tools/256/])
[MPLUGIN-305] MojoAnnotationsScanner should have better control over dependency scanning
Introduce parameter mojoDependencies (rfscholte: [http://svn.apache.org/viewvc/?view=rev&rev=1754998])
* maven-plugin-plugin/pom.xml
* maven-plugin-plugin/src/it/mplugin-305_defaultMojoDependencies
* maven-plugin-plugin/src/it/mplugin-305_defaultMojoDependencies/invoker.properties
* maven-plugin-plugin/src/it/mplugin-305_defaultMojoDependencies/pom.xml
* maven-plugin-plugin/src/it/mplugin-305_defaultMojoDependencies/src
* maven-plugin-plugin/src/it/mplugin-305_defaultMojoDependencies/src/main
* maven-plugin-plugin/src/it/mplugin-305_defaultMojoDependencies/src/main/java
* maven-plugin-plugin/src/it/mplugin-305_defaultMojoDependencies/src/main/java/org
* maven-plugin-plugin/src/it/mplugin-305_defaultMojoDependencies/src/main/java/org/apache
* maven-plugin-plugin/src/it/mplugin-305_defaultMojoDependencies/src/main/java/org/apache/maven
* maven-plugin-plugin/src/it/mplugin-305_defaultMojoDependencies/src/main/java/org/apache/maven/plugins
* maven-plugin-plugin/src/it/mplugin-305_defaultMojoDependencies/src/main/java/org/apache/maven/plugins/plugin
* maven-plugin-plugin/src/it/mplugin-305_defaultMojoDependencies/src/main/java/org/apache/maven/plugins/plugin/it
* maven-plugin-plugin/src/it/mplugin-305_defaultMojoDependencies/src/main/java/org/apache/maven/plugins/plugin/it/CustomSurefireMojo.java
* maven-plugin-plugin/src/it/mplugin-305_defaultMojoDependencies/verify.groovy
* maven-plugin-plugin/src/it/mplugin-305_emptyMojoDependencies
* maven-plugin-plugin/src/it/mplugin-305_emptyMojoDependencies/invoker.properties
* maven-plugin-plugin/src/it/mplugin-305_emptyMojoDependencies/pom.xml
* maven-plugin-plugin/src/it/mplugin-305_emptyMojoDependencies/src
* maven-plugin-plugin/src/it/mplugin-305_emptyMojoDependencies/src/main
* maven-plugin-plugin/src/it/mplugin-305_emptyMojoDependencies/src/main/java
* maven-plugin-plugin/src/it/mplugin-305_emptyMojoDependencies/src/main/java/org
* maven-plugin-plugin/src/it/mplugin-305_emptyMojoDependencies/src/main/java/org/apache
* maven-plugin-plugin/src/it/mplugin-305_emptyMojoDependencies/src/main/java/org/apache/maven
* maven-plugin-plugin/src/it/mplugin-305_emptyMojoDependencies/src/main/java/org/apache/maven/plugins
* maven-plugin-plugin/src/it/mplugin-305_emptyMojoDependencies/src/main/java/org/apache/maven/plugins/plugin
* maven-plugin-plugin/src/it/mplugin-305_emptyMojoDependencies/src/main/java/org/apache/maven/plugins/plugin/it
* maven-plugin-plugin/src/it/mplugin-305_emptyMojoDependencies/src/main/java/org/apache/maven/plugins/plugin/it/CustomSurefireMojo.java
* maven-plugin-plugin/src/it/mplugin-305_emptyMojoDependencies/verify.groovy
* maven-plugin-plugin/src/it/mplugin-305_singleMojoDependencies
* maven-plugin-plugin/src/it/mplugin-305_singleMojoDependencies/invoker.properties
* maven-plugin-plugin/src/it/mplugin-305_singleMojoDependencies/pom.xml
* maven-plugin-plugin/src/it/mplugin-305_singleMojoDependencies/src
* maven-plugin-plugin/src/it/mplugin-305_singleMojoDependencies/src/main
* maven-plugin-plugin/src/it/mplugin-305_singleMojoDependencies/src/main/java
* maven-plugin-plugin/src/it/mplugin-305_singleMojoDependencies/src/main/java/org
* maven-plugin-plugin/src/it/mplugin-305_singleMojoDependencies/src/main/java/org/apache
* maven-plugin-plugin/src/it/mplugin-305_singleMojoDependencies/src/main/java/org/apache/maven
* maven-plugin-plugin/src/it/mplugin-305_singleMojoDependencies/src/main/java/org/apache/maven/plugins
* maven-plugin-plugin/src/it/mplugin-305_singleMojoDependencies/src/main/java/org/apache/maven/plugins/plugin
* maven-plugin-plugin/src/it/mplugin-305_singleMojoDependencies/src/main/java/org/apache/maven/plugins/plugin/it
* maven-plugin-plugin/src/it/mplugin-305_singleMojoDependencies/src/main/java/org/apache/maven/plugins/plugin/it/CustomSurefireMojo.java
* maven-plugin-plugin/src/it/mplugin-305_singleMojoDependencies/verify.groovy
* maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java


> MojoAnnotationsScanner should have better control over dependency scanning
> --------------------------------------------------------------------------
>
>                 Key: MPLUGIN-305
>                 URL: https://issues.apache.org/jira/browse/MPLUGIN-305
>             Project: Maven Plugin Tools
>          Issue Type: Improvement
>          Components: maven-plugin-tools-annotations
>            Reporter: Robert Scholte
>            Assignee: Robert Scholte
>            Priority: Minor
>             Fix For: 3.5
>
>
> Currently MojoAnnotationsScanner always scans all dependencies in search for Mojo's. However, most of the time there's no need to do so: the sources are all the mojo's for the plugin.
> The simple solution would be to specify if the plugin should scan, and maybe even which dependencies.
> A more elegant way would be to analyze the source-classes. If the Mojo's extend known classes like AbstractMojo, there's no need to scan at all.
> ps. plugins which require dependencies-scanning are the maven-surefire-plugin and maven-failsafe-plugin



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)