You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Mark Hindess <ma...@googlemail.com> on 2006/06/21 08:06:16 UTC
[classlib] More build file simplification
I've thought of another few items that I'd like to sort out.
10) Currently the 'build' directory contains sub-directories for 'tests'
and 'test_report' but the compiled classes aren't in a sub-directory.
This seems a bit confused. Perhaps they should go in a sub-directory
'classes' or 'main'? (Also at the module level the tests get put in a
directory called 'bin/test' which seems rather inconsistent.)
11) The basedir for module ant files is the main module directory -
e.g. module/luni. But the tests run in module/luni/bin/test. This
means that relative paths in the ant file all start with
../.. *except* the bootclasspath appends which start ../../../.. which
is a little confusing. Perhaps it would simplify things if tests ran
from the main module directory?
And a quick update on the other items...
1) Moved build.xml up to top-level. Add targets to make top-level
*the* top-level API for developers. I also added a 'help' target with
brief usage information.
Done. Well almost. You can do:
ant -Dbuild.module=luni
and/or:
ant -Dbuild.module=luni test
But:
ant -Dbuild.module=luni clean
probably doesn't do what you might expect.
2) Moved build.xml from modules/*/make to modules/*. Done.
3) Top-level build target doesn't clean anymore. The 'rebuild' target
does. Done. (By Geir IIRC.)
4) Module ant file layers compressed back to one file. Done.
5) Convert XML properties to text.
Not sure this is as easy as I first thought.
6) Use of macros. Ongoing.
7) Removed verbose init targets from module ant files. Done.
8) Fixed module ant file 'clean' targets to clean the class files they
create. Done.
9) Separate exclude lists. Ongoing resurrecting HARMONY-263.
-Mark.
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [classlib] More build file simplification
Posted by Mikhail Loenko <ml...@gmail.com>.
An easy way is return per module targets to build-test.xml and
run them old way. What do you think?
I'd personally avoid spoiling top-level build.xml with too many targets
like that.
Thanks,
Mikhail
2006/6/21, Mark Hindess <ma...@googlemail.com>:
>
> On 21 June 2006 at 13:36, "Mikhail Loenko" <ml...@gmail.com> wrote:
> > 2006/6/21, Mark Hindess <ma...@googlemail.com>:
> > >
> > > On 21 June 2006 at 13:10, "Mikhail Loenko" <ml...@gmail.com> wrote:
> > > >
> > > > how to run tests from two modules and get a single report?
> > >
> > > ant -Dbuild.module=luni test; ant -Dbuild.module=nio test
> >
> > it does not work: the second ant cleans result of the first one
>
> Argh ... default clean ...
>
> How would you suggest we fix it?
>
> > > patches welcome ;-) Tricky without the ant for/if extensions I think.
>
> Regards,
> Mark.
>
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [classlib] More build file simplification
Posted by Mikhail Loenko <ml...@gmail.com>.
2006/6/21, Mark Hindess <ma...@googlemail.com>:
>
> On 21 June 2006 at 13:10, "Mikhail Loenko" <ml...@gmail.com> wrote:
> >
> > how to run tests from two modules and get a single report?
>
> ant -Dbuild.module=luni test; ant -Dbuild.module=nio test
it does not work: the second ant cleans result of the first one
Thanks,
Mikhail
> patches welcome ;-) Tricky without the ant for/if extensions I think.
>
> Regards,
> Mark
>
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [classlib] More build file simplification
Posted by Mikhail Loenko <ml...@gmail.com>.
2006/6/21, Mark Hindess <ma...@googlemail.com>:
>
> I've thought of another few items that I'd like to sort out.
>
> 10) Currently the 'build' directory contains sub-directories for 'tests'
> and 'test_report' but the compiled classes aren't in a sub-directory.
> This seems a bit confused. Perhaps they should go in a sub-directory
> 'classes' or 'main'? (Also at the module level the tests get put in a
> directory called 'bin/test' which seems rather inconsistent.)
>
> 11) The basedir for module ant files is the main module directory -
> e.g. module/luni. But the tests run in module/luni/bin/test. This
> means that relative paths in the ant file all start with
> ../.. *except* the bootclasspath appends which start ../../../.. which
> is a little confusing. Perhaps it would simplify things if tests ran
> from the main module directory?
>
>
> And a quick update on the other items...
>
> 1) Moved build.xml up to top-level. Add targets to make top-level
> *the* top-level API for developers. I also added a 'help' target with
> brief usage information.
>
> Done. Well almost. You can do:
>
> ant -Dbuild.module=luni
how to run tests from two modules and get a single report?
>
> and/or:
>
> ant -Dbuild.module=luni test
>
> But:
>
> ant -Dbuild.module=luni clean
>
> probably doesn't do what you might expect.
>
>
> 2) Moved build.xml from modules/*/make to modules/*. Done.
>
> 3) Top-level build target doesn't clean anymore. The 'rebuild' target
> does. Done. (By Geir IIRC.)
>
> 4) Module ant file layers compressed back to one file. Done.
>
> 5) Convert XML properties to text.
> Not sure this is as easy as I first thought.
>
> 6) Use of macros. Ongoing.
>
> 7) Removed verbose init targets from module ant files. Done.
>
> 8) Fixed module ant file 'clean' targets to clean the class files they
> create. Done.
>
> 9) Separate exclude lists. Ongoing resurrecting HARMONY-263.
>
>
> -Mark.
>
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [classlib] More build file simplification
Posted by Geir Magnusson Jr <ge...@pobox.com>.
Mark Hindess wrote:
>
> And a quick update on the other items...
>
> 1) Moved build.xml up to top-level. Add targets to make top-level
> *the* top-level API for developers. I also added a 'help' target with
> brief usage information.
>
> Done. Well almost. You can do:
For the record, I really am happy to see this back. It's such a pleasure.
[SNIP]
> 5) Convert XML properties to text.
> Not sure this is as easy as I first thought.
Why? Maybe someone has an idea...
geir
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [classlib] More build file simplification
Posted by Geir Magnusson Jr <ge...@pobox.com>.
Mark Hindess wrote:
>
> 9) Separate exclude lists. Ongoing resurrecting HARMONY-263.
>
If this is the one I'm thinking of, and I recall correctly, I'm opposed
to further weaving JUnit dependencies into our infrastructure. I would
assume that we should be able to easily manage the include/exclude lists
all from w/in Ant...
I'll re-read and post more thoughts later.
geir
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org