You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by vrozov <gi...@git.apache.org> on 2016/03/28 22:16:44 UTC
[GitHub] incubator-apex-core pull request: APEXCORE-402
GitHub user vrozov opened a pull request:
https://github.com/apache/incubator-apex-core/pull/286
APEXCORE-402
Provide SpscArrayQueue based implementation that uses Condition to notify publishing thread on not full condition.
@tweise, @PramodSSImmaneni Please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vrozov/incubator-apex-core APEXCORE-402
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-core/pull/286.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #286
----
commit 5e9e6e1c945d27da798c87fe6fc61e4db78118bf
Author: Vlad Rozov <v....@datatorrent.com>
Date: 2016-03-22T03:25:42Z
APEXCORE-402 - Provide SpscArrayQueue based implementation that uses Condition to notify publishing thread on not full condition
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-402
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/286#discussion_r61830152
--- Diff: engine/src/main/java/com/datatorrent/stram/engine/AbstractReservoir.java ---
@@ -47,7 +49,7 @@
{
private static final Logger logger = LoggerFactory.getLogger(AbstractReservoir.class);
static final String reservoirClassNameProperty = "com.datatorrent.stram.engine.Reservoir";
- private static final int USE_SPSC_CAPACITY = 8 * 1024;
+ private static final int USE_SPSC_CAPACITY = 64 * 1024;
--- End diff --
You mean it exceeds SpscArrayQueueReservoir throughput for capacity < 64K? Would be great to see the numbers you got added to the JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-402
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/286#discussion_r61828415
--- Diff: engine/src/main/java/com/datatorrent/stram/engine/AbstractReservoir.java ---
@@ -47,7 +49,7 @@
{
private static final Logger logger = LoggerFactory.getLogger(AbstractReservoir.class);
static final String reservoirClassNameProperty = "com.datatorrent.stram.engine.Reservoir";
- private static final int USE_SPSC_CAPACITY = 8 * 1024;
+ private static final int USE_SPSC_CAPACITY = 64 * 1024;
--- End diff --
As SpscArrayBlockingQueueReservoir provides larger throughtput compared to ArrayBlockingQueueReservoir, it exceeds throughput of SpscReservoir for larger queue capacity.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-402
Posted by vrozov <gi...@git.apache.org>.
GitHub user vrozov reopened a pull request:
https://github.com/apache/incubator-apex-core/pull/286
APEXCORE-402
Provide SpscArrayQueue based implementation that uses Condition to notify publishing thread on not full condition.
@tweise, @PramodSSImmaneni Please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vrozov/incubator-apex-core APEXCORE-402
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-core/pull/286.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #286
----
commit a0e17c2f6fe693b2986ac38f4d283b4eaab81927
Author: Vlad Rozov <v....@datatorrent.com>
Date: 2016-03-22T03:25:42Z
APEXCORE-402 - Provide SpscArrayQueue based implementation that uses Condition to notify publishing thread on not full condition
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-402
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-core/pull/286
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-402
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov closed the pull request at:
https://github.com/apache/incubator-apex-core/pull/286
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-402
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/286#discussion_r61825724
--- Diff: engine/src/main/java/com/datatorrent/stram/engine/AbstractReservoir.java ---
@@ -47,7 +49,7 @@
{
private static final Logger logger = LoggerFactory.getLogger(AbstractReservoir.class);
static final String reservoirClassNameProperty = "com.datatorrent.stram.engine.Reservoir";
- private static final int USE_SPSC_CAPACITY = 8 * 1024;
+ private static final int USE_SPSC_CAPACITY = 64 * 1024;
--- End diff --
Name, the constant now is the threshold for blocking queue, it's spsc in either case. Why did it increase?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---