You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by dr...@apache.org on 2007/08/28 21:03:27 UTC

svn commit: r570528 - in /myfaces/trinidad/trunk/trinidad: src/site/xdoc/ src/site/xdoc/devguide/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/...

Author: drobinson
Date: Tue Aug 28 12:03:27 2007
New Revision: 570528

URL: http://svn.apache.org/viewvc?rev=570528&view=rev
Log:
TRINIDAD-660
Made settings public
org.apache.myfaces.trinidadinternal.renderkit.USE_DIALOG_POPUP
became
org.apache.myfaces.trinidad.renderkit.ENABLE_LIGHTWEIGHT_DIALOGS
AND
org.apache.myfaces.trinidadinternal.DISABLE_CONTENT_COMPRESSION
became
org.apache.myfaces.trinidad.DISABLE_CONTENT_COMPRESSION

Modified:
    myfaces/trinidad/trunk/trinidad/src/site/xdoc/devguide/configuration.xml
    myfaces/trinidad/trunk/trinidad/src/site/xdoc/devguide/skinning.xml
    myfaces/trinidad/trunk/trinidad/src/site/xdoc/release-notes.xml
    myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderKit.java
    myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/StyleSheetRenderer.java
    myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/share/config/Configuration.java

Modified: myfaces/trinidad/trunk/trinidad/src/site/xdoc/devguide/configuration.xml
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad/src/site/xdoc/devguide/configuration.xml?rev=570528&r1=570527&r2=570528&view=diff
==============================================================================
--- myfaces/trinidad/trunk/trinidad/src/site/xdoc/devguide/configuration.xml (original)
+++ myfaces/trinidad/trunk/trinidad/src/site/xdoc/devguide/configuration.xml Tue Aug 28 12:03:27 2007
@@ -16,7 +16,7 @@
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
-	   
+     
 -->
 <document>
   <properties>
@@ -344,6 +344,15 @@
 flag can be set to true to turn off the obfuscation.
 </p>
 </subsection>
+<subsection name="org.apache.myfaces.trinidad.DISABLE_CONTENT_COMPRESSION">
+<p>
+Apache Trinidad by default compresses the style class names inside the css that
+is generated on the server.  However, when developing custom Trinidad skins, it
+is much easier to work with the non-compressed style class names, which much more
+directly relate to those used in the skin css file.  This flag can be set to turn
+off automatic compression of style class names.
+</p>
+</subsection>
 <subsection name="org.apache.myfaces.trinidad.CHECK_FILE_MODIFICATION">
 <p>
 If this parameter is enabled by setting to "true", Apache Trinidad will automatically
@@ -351,6 +360,14 @@
 state when they change;  this makes development easier,
 but adds overhead that should be avoided when your application
 is deployed.
+</p>
+</subsection>
+<subsection name="org.apache.myfaces.trinidad.renderkit.ENABLE_LIGHTWEIGHT_DIALOGS">
+<p>
+Trinidad supports two dialog implementations.  The default implementation pops a new
+browser window, but may be subject to popup blocking issues depending on the browser.
+The alternative lightweight implementation uses a skinnable modal iframe that hovers 
+over the existing page.  This flag can be set to turn on lightweight dialogs.
 </p>
 </subsection>
 <subsection name="File upload configuration">

Modified: myfaces/trinidad/trunk/trinidad/src/site/xdoc/devguide/skinning.xml
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad/src/site/xdoc/devguide/skinning.xml?rev=570528&r1=570527&r2=570528&view=diff
==============================================================================
--- myfaces/trinidad/trunk/trinidad/src/site/xdoc/devguide/skinning.xml (original)
+++ myfaces/trinidad/trunk/trinidad/src/site/xdoc/devguide/skinning.xml Tue Aug 28 12:03:27 2007
@@ -16,7 +16,7 @@
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
-	   
+     
 -->
 <document>
   <properties>
@@ -693,7 +693,7 @@
         <source>
                   <![CDATA[
         <context-param>
-         <param-name>org.apache.myfaces.trinidadinternal.DISABLE_CONTENT_COMPRESSION</param-name>
+         <param-name>org.apache.myfaces.trinidad.DISABLE_CONTENT_COMPRESSION</param-name>
          <param-value>true</param-value>
         </context-param>
                     ]]>

Modified: myfaces/trinidad/trunk/trinidad/src/site/xdoc/release-notes.xml
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad/src/site/xdoc/release-notes.xml?rev=570528&r1=570527&r2=570528&view=diff
==============================================================================
--- myfaces/trinidad/trunk/trinidad/src/site/xdoc/release-notes.xml (original)
+++ myfaces/trinidad/trunk/trinidad/src/site/xdoc/release-notes.xml Tue Aug 28 12:03:27 2007
@@ -53,8 +53,14 @@
 </subsection>
 
 <subsection name="Changes from previous release">
-  <ul>
-  </ul>
+<ul>
+<li>Non-public web.xml setting 'org.apache.myfaces.trinidadinternal.DISABLE_CONTENT_COMPRESSION' 
+made public as 'org.apache.myfaces.trinidad.DISABLE_CONTENT_COMPRESSION'.
+</li>
+<li>Non-public web.xml setting 'org.apache.myfaces.trinidadinternal.renderkit.USE_DIALOG_POPUP' 
+made public as 'org.apache.myfaces.trinidad.renderkit.ENABLE_LIGHTWEIGHT_DIALOGS'.
+</li>
+</ul>
 </subsection>
 
         

Modified: myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderKit.java
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderKit.java?rev=570528&r1=570527&r2=570528&view=diff
==============================================================================
--- myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderKit.java (original)
+++ myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderKit.java Tue Aug 28 12:03:27 2007
@@ -836,7 +836,7 @@
   static private final String _PPR_REQUEST_HEADER = "Tr-XHR-Message";
 
   static private final String _USE_DIALOG_POPUP_INIT_PARAM =
-    "org.apache.myfaces.trinidadinternal.renderkit.USE_DIALOG_POPUP";
+    "org.apache.myfaces.trinidad.renderkit.ENABLE_LIGHTWEIGHT_DIALOGS";
 
   static private final TrinidadLogger _LOG =
     TrinidadLogger.createTrinidadLogger(CoreRenderKit.class);

Modified: myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/StyleSheetRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/StyleSheetRenderer.java?rev=570528&r1=570527&r2=570528&view=diff
==============================================================================
--- myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/StyleSheetRenderer.java (original)
+++ myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/StyleSheetRenderer.java Tue Aug 28 12:03:27 2007
@@ -52,12 +52,12 @@
    * implementations should attempt to reduce the size of generated
    * content, for example, by compressing style class names.  These
    * optimizations are enabled by default.  In general,
-   * clients should not need to disable these optimizations.  However,
-   * clients that want to disable this functionality for testing or
-   * debugging purposes can do so by setting this property to Boolean.TRUE.
+   * users should not need to disable these optimizations.  However,
+   * users who want to build custom skins for Trinidad will find this
+   * setting essential.  Use Boolean.TRUE to disable compression.
    */
   static public final String DISABLE_CONTENT_COMPRESSION =
-    "org.apache.myfaces.trinidadinternal.DISABLE_CONTENT_COMPRESSION";
+    "org.apache.myfaces.trinidad.DISABLE_CONTENT_COMPRESSION";
 
   public StyleSheetRenderer()
   {

Modified: myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/share/config/Configuration.java
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/share/config/Configuration.java?rev=570528&r1=570527&r2=570528&view=diff
==============================================================================
--- myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/share/config/Configuration.java (original)
+++ myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/share/config/Configuration.java Tue Aug 28 12:03:27 2007
@@ -38,12 +38,12 @@
    * implementations should attempt to reduce the size of generated
    * content, for example, by compressing style class names.  These
    * optimizations are enabled by default.  In general,
-   * clients should not need to disable these optimizations.  However,
-   * clients that want to disable this functionality for testing or
-   * debugging purposes can do so by setting this property to Boolean.TRUE.
+   * users should not need to disable these optimizations.  However,
+   * users who want to build custom skins for Trinidad will find this
+   * setting essential.  Use Boolean.TRUE to disable compression.
    */
   static public final String DISABLE_CONTENT_COMPRESSION =
-    "org.apache.myfaces.trinidadinternal.DISABLE_CONTENT_COMPRESSION";
+    "org.apache.myfaces.trinidad.DISABLE_CONTENT_COMPRESSION";
 
   /**
    * Key for the base UIX directory.