You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/12 15:55:25 UTC

[GitHub] [flink] snuyanzin opened a new pull request, #21494: [hotfix][table-common] Remove unused private methods

snuyanzin opened a new pull request, #21494:
URL: https://github.com/apache/flink/pull/21494

   The PR removes 2 private unused methods from `flink-table-common`
   
   ## What is the purpose of the change
   `org.apache.flink.table.factories.TableFactoryService#filterSupportedPropertiesFactorySpecific` The usage was removed at https://github.com/apache/flink/commit/8212230414f0c49a9f5b636bfc5101417e921a66#diff-b95578386c94cdc85a50a5514cbf34e3a5964eac6b9c71c2e22a810bf142bc9aL392-L393
   
   `explicitNotFromFamily` from `org.apache.flink.table.types.logical.utils.LogicalTypeCasts` The usage was removed at 
   https://github.com/apache/flink/commit/7dc419342779d08f6c1ae6adf42e58bdc6056971
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): ( no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
     - The serializers: ( no)
     - The runtime per-record code paths (performance sensitive): ( no )
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no)
     - The S3 file system connector: ( no )
   
   ## Documentation
   
     - Does this pull request introduce a new feature? ( no)
     - If yes, how is the feature documented? (not applicable )
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21494: [hotfix][table-common] Remove unused private methods

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21494:
URL: https://github.com/apache/flink/pull/21494#issuecomment-1346785690

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "26a224ead6408bdb6a4861dd9596b20cb406f142",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "26a224ead6408bdb6a4861dd9596b20cb406f142",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 26a224ead6408bdb6a4861dd9596b20cb406f142 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp merged pull request #21494: [hotfix][table-common] Remove unused private methods

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp merged PR #21494:
URL: https://github.com/apache/flink/pull/21494


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gunnarmorling commented on pull request #21494: [hotfix][table-common] Remove unused private methods

Posted by GitBox <gi...@apache.org>.
gunnarmorling commented on PR #21494:
URL: https://github.com/apache/flink/pull/21494#issuecomment-1362938973

   @MartijnVisser, this seems good, WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org