You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beam.apache.org by Charith Ellawala <ch...@gmail.com> on 2019/05/20 12:41:18 UTC

[BEAM-6673] pre-commit checks failing due to test failure in unrelated Docker module

Hello,

I am trying to create a PR for BEAM-6673 which adds schema support for
BigQuery reads (https://github.com/apache/beam/pull/8620). However, one of
the pre-commit tests is failing in the (unrelated) Docker module:

*Task :sdks:java:container:docker* FAILEDADD failed: stat
/var/lib/docker/tmp/docker-builder145327764/target/kafka-clients.jar:
no such file or directory


I have not touched this code so the test failure is not caused by any of my
changes. I have tried re-running the test suite but the failure still
persists. From a quick glance, it looks like the kafka-clients dependency
is designated as "provided" so perhaps the failure is caused by the Jenkins
machine not having the required jar file? I would really appreciate some
help with resolving this issue so that I can submit my PR for review.

Thank you.

Best regards,
Charith

Re: [BEAM-6673] pre-commit checks failing due to test failure in unrelated Docker module

Posted by ch...@gmail.com, ch...@gmail.com.
Thank you. 

On 2019/05/20 13:16:06, Robert Bradshaw <ro...@google.com> wrote: 
> I created https://issues.apache.org/jira/browse/BEAM-7367
> 
> On Mon, May 20, 2019 at 3:11 PM Michael Luckey <ad...@gmail.com> wrote:
> >
> > This is most likely caused by Merge of https://issues.apache.org/jira/browse/BEAM-7349, which was done lately.
> >
> > Best,
> >
> > michel
> >
> > On Mon, May 20, 2019 at 2:49 PM Charith Ellawala <ch...@gmail.com> wrote:
> >>
> >> Hello,
> >>
> >> I am trying to create a PR for BEAM-6673 which adds schema support for BigQuery reads (https://github.com/apache/beam/pull/8620). However, one of the pre-commit tests is failing in the (unrelated) Docker module:
> >>
> >> Task :sdks:java:container:docker FAILED
> >> ADD failed: stat /var/lib/docker/tmp/docker-builder145327764/target/kafka-clients.jar: no such file or directory
> >>
> >>
> >> I have not touched this code so the test failure is not caused by any of my changes. I have tried re-running the test suite but the failure still persists. From a quick glance, it looks like the kafka-clients dependency is designated as "provided" so perhaps the failure is caused by the Jenkins machine not having the required jar file? I would really appreciate some help with resolving this issue so that I can submit my PR for review.
> >>
> >> Thank you.
> >>
> >> Best regards,
> >> Charith
> 

Re: [BEAM-6673] pre-commit checks failing due to test failure in unrelated Docker module

Posted by ch...@gmail.com, ch...@gmail.com.
That was quick! Thanks Maximilian and Alexey.



On 2019/05/20 15:47:10, Alexey Romanenko <ar...@gmail.com> wrote: 
> Charith,
> 
> Yes, it was caused by changing a scope of "kafka-clients" dependency. Now it should work fine (I run “JavaPortabilityApi” test on your PR and it’s green), thanks to Maximilian Michels for quick fix.
> Sorry for inconvenience. 
> 
> > On 20 May 2019, at 16:24, Maximilian Michels <mx...@apache.org> wrote:
> > 
> > I've opened a PR: https://github.com/apache/beam/pull/8625
> > 
> > Due to the provided scope, we have to add it as an explicit dependency to the container task.
> > 
> > Thanks,
> > Max
> > 
> > On 20.05.19 15:16, Robert Bradshaw wrote:
> >> I created https://issues.apache.org/jira/browse/BEAM-7367
> >> On Mon, May 20, 2019 at 3:11 PM Michael Luckey <ad...@gmail.com> wrote:
> >>> 
> >>> This is most likely caused by Merge of https://issues.apache.org/jira/browse/BEAM-7349, which was done lately.
> >>> 
> >>> Best,
> >>> 
> >>> michel
> >>> 
> >>> On Mon, May 20, 2019 at 2:49 PM Charith Ellawala <ch...@gmail.com> wrote:
> >>>> 
> >>>> Hello,
> >>>> 
> >>>> I am trying to create a PR for BEAM-6673 which adds schema support for BigQuery reads (https://github.com/apache/beam/pull/8620). However, one of the pre-commit tests is failing in the (unrelated) Docker module:
> >>>> 
> >>>> Task :sdks:java:container:docker FAILED
> >>>> ADD failed: stat /var/lib/docker/tmp/docker-builder145327764/target/kafka-clients.jar: no such file or directory
> >>>> 
> >>>> 
> >>>> I have not touched this code so the test failure is not caused by any of my changes. I have tried re-running the test suite but the failure still persists. From a quick glance, it looks like the kafka-clients dependency is designated as "provided" so perhaps the failure is caused by the Jenkins machine not having the required jar file? I would really appreciate some help with resolving this issue so that I can submit my PR for review.
> >>>> 
> >>>> Thank you.
> >>>> 
> >>>> Best regards,
> >>>> Charith
> 
> 

Re: [BEAM-6673] pre-commit checks failing due to test failure in unrelated Docker module

Posted by Alexey Romanenko <ar...@gmail.com>.
Charith,

Yes, it was caused by changing a scope of "kafka-clients" dependency. Now it should work fine (I run “JavaPortabilityApi” test on your PR and it’s green), thanks to Maximilian Michels for quick fix.
Sorry for inconvenience. 

> On 20 May 2019, at 16:24, Maximilian Michels <mx...@apache.org> wrote:
> 
> I've opened a PR: https://github.com/apache/beam/pull/8625
> 
> Due to the provided scope, we have to add it as an explicit dependency to the container task.
> 
> Thanks,
> Max
> 
> On 20.05.19 15:16, Robert Bradshaw wrote:
>> I created https://issues.apache.org/jira/browse/BEAM-7367
>> On Mon, May 20, 2019 at 3:11 PM Michael Luckey <ad...@gmail.com> wrote:
>>> 
>>> This is most likely caused by Merge of https://issues.apache.org/jira/browse/BEAM-7349, which was done lately.
>>> 
>>> Best,
>>> 
>>> michel
>>> 
>>> On Mon, May 20, 2019 at 2:49 PM Charith Ellawala <ch...@gmail.com> wrote:
>>>> 
>>>> Hello,
>>>> 
>>>> I am trying to create a PR for BEAM-6673 which adds schema support for BigQuery reads (https://github.com/apache/beam/pull/8620). However, one of the pre-commit tests is failing in the (unrelated) Docker module:
>>>> 
>>>> Task :sdks:java:container:docker FAILED
>>>> ADD failed: stat /var/lib/docker/tmp/docker-builder145327764/target/kafka-clients.jar: no such file or directory
>>>> 
>>>> 
>>>> I have not touched this code so the test failure is not caused by any of my changes. I have tried re-running the test suite but the failure still persists. From a quick glance, it looks like the kafka-clients dependency is designated as "provided" so perhaps the failure is caused by the Jenkins machine not having the required jar file? I would really appreciate some help with resolving this issue so that I can submit my PR for review.
>>>> 
>>>> Thank you.
>>>> 
>>>> Best regards,
>>>> Charith


Re: [BEAM-6673] pre-commit checks failing due to test failure in unrelated Docker module

Posted by Maximilian Michels <mx...@apache.org>.
I've opened a PR: https://github.com/apache/beam/pull/8625

Due to the provided scope, we have to add it as an explicit dependency 
to the container task.

Thanks,
Max

On 20.05.19 15:16, Robert Bradshaw wrote:
> I created https://issues.apache.org/jira/browse/BEAM-7367
> 
> On Mon, May 20, 2019 at 3:11 PM Michael Luckey <ad...@gmail.com> wrote:
>>
>> This is most likely caused by Merge of https://issues.apache.org/jira/browse/BEAM-7349, which was done lately.
>>
>> Best,
>>
>> michel
>>
>> On Mon, May 20, 2019 at 2:49 PM Charith Ellawala <ch...@gmail.com> wrote:
>>>
>>> Hello,
>>>
>>> I am trying to create a PR for BEAM-6673 which adds schema support for BigQuery reads (https://github.com/apache/beam/pull/8620). However, one of the pre-commit tests is failing in the (unrelated) Docker module:
>>>
>>> Task :sdks:java:container:docker FAILED
>>> ADD failed: stat /var/lib/docker/tmp/docker-builder145327764/target/kafka-clients.jar: no such file or directory
>>>
>>>
>>> I have not touched this code so the test failure is not caused by any of my changes. I have tried re-running the test suite but the failure still persists. From a quick glance, it looks like the kafka-clients dependency is designated as "provided" so perhaps the failure is caused by the Jenkins machine not having the required jar file? I would really appreciate some help with resolving this issue so that I can submit my PR for review.
>>>
>>> Thank you.
>>>
>>> Best regards,
>>> Charith

Re: [BEAM-6673] pre-commit checks failing due to test failure in unrelated Docker module

Posted by Robert Bradshaw <ro...@google.com>.
I created https://issues.apache.org/jira/browse/BEAM-7367

On Mon, May 20, 2019 at 3:11 PM Michael Luckey <ad...@gmail.com> wrote:
>
> This is most likely caused by Merge of https://issues.apache.org/jira/browse/BEAM-7349, which was done lately.
>
> Best,
>
> michel
>
> On Mon, May 20, 2019 at 2:49 PM Charith Ellawala <ch...@gmail.com> wrote:
>>
>> Hello,
>>
>> I am trying to create a PR for BEAM-6673 which adds schema support for BigQuery reads (https://github.com/apache/beam/pull/8620). However, one of the pre-commit tests is failing in the (unrelated) Docker module:
>>
>> Task :sdks:java:container:docker FAILED
>> ADD failed: stat /var/lib/docker/tmp/docker-builder145327764/target/kafka-clients.jar: no such file or directory
>>
>>
>> I have not touched this code so the test failure is not caused by any of my changes. I have tried re-running the test suite but the failure still persists. From a quick glance, it looks like the kafka-clients dependency is designated as "provided" so perhaps the failure is caused by the Jenkins machine not having the required jar file? I would really appreciate some help with resolving this issue so that I can submit my PR for review.
>>
>> Thank you.
>>
>> Best regards,
>> Charith

Re: [BEAM-6673] pre-commit checks failing due to test failure in unrelated Docker module

Posted by Michael Luckey <ad...@gmail.com>.
This is most likely caused by Merge of
https://issues.apache.org/jira/browse/BEAM-7349, which was done lately.

Best,

michel

On Mon, May 20, 2019 at 2:49 PM Charith Ellawala <ch...@gmail.com>
wrote:

> Hello,
>
> I am trying to create a PR for BEAM-6673 which adds schema support for
> BigQuery reads (https://github.com/apache/beam/pull/8620). However, one
> of the pre-commit tests is failing in the (unrelated) Docker module:
>
> *Task :sdks:java:container:docker* FAILEDADD failed: stat /var/lib/docker/tmp/docker-builder145327764/target/kafka-clients.jar: no such file or directory
>
>
> I have not touched this code so the test failure is not caused by any of
> my changes. I have tried re-running the test suite but the failure still
> persists. From a quick glance, it looks like the kafka-clients dependency
> is designated as "provided" so perhaps the failure is caused by the Jenkins
> machine not having the required jar file? I would really appreciate some
> help with resolving this issue so that I can submit my PR for review.
>
> Thank you.
>
> Best regards,
> Charith
>

Re: [BEAM-6673] pre-commit checks failing due to test failure in unrelated Docker module

Posted by Robert Bradshaw <ro...@google.com>.
I have no idea about this failure, but it sounds like you've done due
diligence looking into it at this point and it makes sense to ask some
reviewers to take a look at your code which can happen in parallel to
figuring out the root cuase of this kafka issue before it finally gets
submitted.

On Mon, May 20, 2019 at 2:49 PM Charith Ellawala
<ch...@gmail.com> wrote:
>
> Hello,
>
> I am trying to create a PR for BEAM-6673 which adds schema support for BigQuery reads (https://github.com/apache/beam/pull/8620). However, one of the pre-commit tests is failing in the (unrelated) Docker module:
>
> Task :sdks:java:container:docker FAILED
> ADD failed: stat /var/lib/docker/tmp/docker-builder145327764/target/kafka-clients.jar: no such file or directory
>
>
> I have not touched this code so the test failure is not caused by any of my changes. I have tried re-running the test suite but the failure still persists. From a quick glance, it looks like the kafka-clients dependency is designated as "provided" so perhaps the failure is caused by the Jenkins machine not having the required jar file? I would really appreciate some help with resolving this issue so that I can submit my PR for review.
>
> Thank you.
>
> Best regards,
> Charith