You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by purplecabbage <gi...@git.apache.org> on 2017/06/26 23:25:06 UTC

[GitHub] cordova-browser pull request #35: CB-11181 add default favicon

GitHub user purplecabbage opened a pull request:

    https://github.com/apache/cordova-browser/pull/35

    CB-11181 add default favicon

    
    ### Platforms affected
    Browser
    
    ### What does this PR do?
    adds default favicon, that 'should' be overwritten by apps targeting browser, this avoids a 404 shown in console.error
    
    ### What testing has been done on this change?
    manual
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/purplecabbage/cordova-browser CB-11181

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-browser/pull/35.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #35
    
----
commit db6d1180296b8578a596e6f03d5b4adc49e5fff6
Author: Jesse MacFadyen <pu...@gmail.com>
Date:   2017-06-26T23:22:50Z

    CB-11181 add default favicon

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-browser pull request #35: CB-11181 add default favicon

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-browser/pull/35


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org