You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by blbradley <gi...@git.apache.org> on 2016/01/24 05:50:38 UTC
[GitHub] spark pull request: [SPARK-12972][CORE] update httpclient to 4.5.1
GitHub user blbradley opened a pull request:
https://github.com/apache/spark/pull/10887
[SPARK-12972][CORE] update httpclient to 4.5.1
looking to fix some dependency issues
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/blbradley/spark spark-12972
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10887.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10887
----
commit 4eea1c8be1fe0d1070d6f5331ee547252d689f46
Author: Brandon Bradley <br...@gmail.com>
Date: 2016-01-24T04:47:36Z
[SPARK-12972][CORE] update httpclient to 4.5.1
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12972][CORE] update httpclient to 4.5.1
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/10887#issuecomment-174334765
I'm on the verge of just publishing my own shaded `docker-client` since nobody seems to want to review / shepherd [my shading fixes](https://github.com/spotify/docker-client/pull/272) for the Spotify version (and also because it's going to be a larger change to publish with dependency-reduced POMs).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12972][CORE] update httpclient to 4.5.1
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10887#issuecomment-174318128
**[Test build #2449 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2449/consoleFull)** for PR 10887 at commit [`4eea1c8`](https://github.com/apache/spark/commit/4eea1c8be1fe0d1070d6f5331ee547252d689f46).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12972][CORE] update httpclient to 4.5.1
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10887#issuecomment-174319218
**[Test build #2449 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2449/consoleFull)** for PR 10887 at commit [`4eea1c8`](https://github.com/apache/spark/commit/4eea1c8be1fe0d1070d6f5331ee547252d689f46).
* This patch **fails build dependency tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12972][CORE] update httpclient to 4.5.1
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10887#issuecomment-174288516
My major question is simply, does this break anything? the problem is that not all transitive dependencies use this version of the httpclient. Although I suspect it would be OK, assuming 4.5 is backwards-compatible with 4.3, and tests would help reveal problems (and you're going to have to update the dependencies file in the repo anyway to reflect the change), then this is substantially OK.
Is there a particular fix we need in 4.5?
One good thing to do is examine the current set of dependencies and evaluate all the different versions of this we use, and from where, and skim release notes to see if there are likely any breaking changes.
Secondly, we probably need to clean up handling of this dependency more thoroughly. Version needs to be declared once in the parent, and we probably need to remove most if not all exclusions of this at this stage. They should be redundant, but that also bears thinking through.
It's not a trivial exercise, but it would certainly help to study the state of this fairly important dependency and clean it up. We can tolerate a little breakage risk with Spark 2.x.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12972][CORE] update httpclient to 4.5.1
Posted by blbradley <gi...@git.apache.org>.
Github user blbradley commented on the pull request:
https://github.com/apache/spark/pull/10887#issuecomment-174302616
@srowen (SPARK-11796)[https://issues.apache.org/jira/browse/SPARK-11796] brought the Docker integration tests to 4.5. They still break depending on how they are run (in IntelliJ, for example). Until `docker-client` uses shaded jars (see [this comment](https://github.com/apache/spark/pull/9876#issuecomment-159065048)), updating this dependency may be the best approach.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12972][CORE] update httpclient to 4.5.1
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10887#issuecomment-174253584
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12972][CORE] update httpclient to 4.5.1
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10887#issuecomment-217510115
@blbradley are you interested in following up on this? this could be a good update for 2.0. This would need a rebase, and needs to also edit the "deps/*" files so we can see what dependencies changed. The thing I would be worried about is that the transitive dependency graph would still contain older versions of Commons Http-related artifacts, which may require a little more massaging. Conceptually, this is good though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12972][CORE] update httpclient to 4.5.1
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10887#issuecomment-184331000
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12972][CORE] update httpclient to 4.5.1
Posted by blbradley <gi...@git.apache.org>.
Github user blbradley commented on the pull request:
https://github.com/apache/spark/pull/10887#issuecomment-174321435
I didn't know there was a dependency test. That helps!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12972][CORE] update httpclient to 4.5.1
Posted by blbradley <gi...@git.apache.org>.
Github user blbradley commented on the pull request:
https://github.com/apache/spark/pull/10887#issuecomment-174309171
Tests on `core` sub-project passed. Can we give Jenkins a roll?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12972][CORE] update httpclient to 4.5.1
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10887
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12972][CORE] update httpclient to 4.5.1
Posted by blbradley <gi...@git.apache.org>.
Github user blbradley commented on the pull request:
https://github.com/apache/spark/pull/10887#issuecomment-174300376
I don't know if it breaks anything yet. I ran the tests locally, but I'm not sure how to tell if/how many tests failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org