You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/03 12:11:51 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly

HyukjinKwon commented on a change in pull request #28808:
URL: https://github.com/apache/spark/pull/28808#discussion_r449551076



##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
##########
@@ -884,4 +884,15 @@ class AnalysisSuite extends AnalysisTest with Matchers {
       Seq("Intersect can only be performed on tables with the compatible column types. " +
         "timestamp <> double at the second column of the second table"))
   }
+
+  test("throw user facing error when use WindowFunction directly") {

Review comment:
       Shall we add a JIRA prefix here? `SPARK-31975: ...`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org