You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/02/19 20:22:05 UTC
[GitHub] [hive] kgyrtkirk opened a new pull request #919: HIVE-22881 rexutil
usage
kgyrtkirk opened a new pull request #919: HIVE-22881 rexutil usage
URL: https://github.com/apache/hive/pull/919
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on a change in pull request #919:
HIVE-22881 rexutil usage
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on a change in pull request #919: HIVE-22881 rexutil usage
URL: https://github.com/apache/hive/pull/919#discussion_r381806268
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsWithStatsRule.java
##########
@@ -272,7 +274,11 @@ public RexNode visitCall(RexCall call) {
// If we did not reduce, check the children nodes
RexNode node = super.visitCall(call);
if (node != call) {
- node = RexUtil.simplify(rexBuilder, node);
+ // FIXME if this rule will make some changes; then it will invoke simplify on all subtrees during exiting the recursion
Review comment:
It was there before; and I can't really do anything right now with it...leaving a comment might be usefull if it lights up on someones profiler
To fix this we would need some way to keep track which nodes were simplified already...that should be fixed in Calcite;and it might not even possible (because the set of predicates might be different )
We might consider moving the simplification outside of the recursive phase - that will certainly reduce the re-visit pressure; but could result in reduced simplification in some cases (however considering how many places we are doing this, that's unlikely) - it could be explored in a separate patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk closed pull request #919: HIVE-22881 rexutil usage
Posted by GitBox <gi...@apache.org>.
kgyrtkirk closed pull request #919: HIVE-22881 rexutil usage
URL: https://github.com/apache/hive/pull/919
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] jcamachor commented on a change in pull request #919:
HIVE-22881 rexutil usage
Posted by GitBox <gi...@apache.org>.
jcamachor commented on a change in pull request #919: HIVE-22881 rexutil usage
URL: https://github.com/apache/hive/pull/919#discussion_r381679711
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsWithStatsRule.java
##########
@@ -272,7 +274,11 @@ public RexNode visitCall(RexCall call) {
// If we did not reduce, check the children nodes
RexNode node = super.visitCall(call);
if (node != call) {
- node = RexUtil.simplify(rexBuilder, node);
+ // FIXME if this rule will make some changes; then it will invoke simplify on all subtrees during exiting the recursion
Review comment:
Is this to fix in this patch or in a follow-up? Can you create a JIRA if that is the case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org