You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by fe...@apache.org on 2011/03/20 21:56:23 UTC
svn commit: r1083566 -
/directory/shared/trunk/asn1/ber/src/main/java/org/apache/directory/shared/asn1/ber/tlv/Value.java
Author: felixk
Date: Sun Mar 20 20:56:23 2011
New Revision: 1083566
URL: http://svn.apache.org/viewvc?rev=1083566&view=rev
Log:
May expose internal representation (http://findbugs.sourceforge.net/bugDescriptions.html#EI_EXPOSE_REP)
Modified:
directory/shared/trunk/asn1/ber/src/main/java/org/apache/directory/shared/asn1/ber/tlv/Value.java
Modified: directory/shared/trunk/asn1/ber/src/main/java/org/apache/directory/shared/asn1/ber/tlv/Value.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/asn1/ber/src/main/java/org/apache/directory/shared/asn1/ber/tlv/Value.java?rev=1083566&r1=1083565&r2=1083566&view=diff
==============================================================================
--- directory/shared/trunk/asn1/ber/src/main/java/org/apache/directory/shared/asn1/ber/tlv/Value.java (original)
+++ directory/shared/trunk/asn1/ber/src/main/java/org/apache/directory/shared/asn1/ber/tlv/Value.java Sun Mar 20 20:56:23 2011
@@ -153,7 +153,7 @@ public class Value
*/
public byte[] getData()
{
- return data;
+ return data.clone();
}
Re: svn commit: r1083566 - /directory/shared/trunk/asn1/ber/src/main/java/org/apache/directory/shared/asn1/ber/tlv/Value.java
Posted by Emmanuel Lecharny <el...@gmail.com>.
On 3/20/11 9:56 PM, felixk@apache.org wrote:
> Author: felixk
> Date: Sun Mar 20 20:56:23 2011
> New Revision: 1083566
Hi Felix,
the return of the direct value (without cloning) was intended. Even if
we modify the interned value, it won't have any impact, so there is no
need to clone it.
--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com