[jira] Commented: (WICKET-1888) FormComponents (and subclasses) should be able to provide their own resource bundles

["Juergen Donnerstag (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660078#action_12660078 ] 

Juergen Donnerstag commented on WICKET-1888:
--------------------------------------------

This is the code copied from 1.4 trunk


			final Localizer localizer = formComponent.getLocalizer();

			String resource = prefix + getId() + "." + key;

			// First use the parent for resolving so that
			// form1.textfield1.Required can be used.
			String message = getString(localizer, resource, formComponent.getParent());

			// If not found, than ...
			if (Strings.isEmpty(message))
			{
				// Try a variation of the resource key
				resource = prefix + key;
				message = getString(localizer, resource, formComponent.getParent());
			}

			if (Strings.isEmpty(message))
			{
				// If still empty then use default
				resource = prefix + getId() + "." + key;
				message = getString(localizer, resource, formComponent);

				// If not found, than ...
				if (Strings.isEmpty(message))
				{
					// Try a variation of the resource key
					resource = prefix + key;
					message = getString(localizer, resource, formComponent);
				}
			}

Based on that code, formComponent.getParent() is just the first attempt. If that fails formComponent is used.


> FormComponents (and subclasses) should be able to provide their own resource bundles
> ------------------------------------------------------------------------------------
>
>                 Key: WICKET-1888
>                 URL: https://issues.apache.org/jira/browse/WICKET-1888
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.4
>            Reporter: Christian Oldiges
>            Priority: Minor
>
> In order to fully support the idea to break down a large application into small reusable components it seems necessary that FormComponents provide their own resource bundles. We have a project that uses a customized subclass of Checkbox that needs to provide customized error messages. The ideal place for those error messages would be a resource bundle living next to the Checkbox subclass but this is not yet supported. Unfortunately the JavaDoc for ComponentStringResourceLoader indicates (see example: input1.properties => Required) that support for this already exists.
> A small change to FormComponent$MessageSource.getMessage(String key) could add support for this. Instead of using the formComponent.getParent() as the base for searching the resource string, simply use the formComponent itself.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.