You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Jeff Trawick <tr...@gmail.com> on 2014/06/19 20:15:48 UTC
fix a technicality with struct sockaddr_un in 1.6.x branch???
Index: include/apr_network_io.h
===================================================================
--- include/apr_network_io.h (revision 1603975)
+++ include/apr_network_io.h (working copy)
@@ -267,13 +267,17 @@
#endif
#if APR_HAVE_SA_STORAGE
/** Placeholder to ensure that the size of this union is not
- * dependent on whether APR_HAVE_IPV6 is defined. */
+ * dependent on whether APR_HAVE_IPV6 or APR_HAVE_SOCKADDR_UN
+ * is defined. */
struct sockaddr_storage sas;
-#endif
#if APR_HAVE_SOCKADDR_UN
- /** Unix domain socket sockaddr structure */
+ /** Unix domain socket sockaddr structure; note that adding
+ * this when sockaddr_storage isn't available breaks
+ * binary compatibility
+ */
struct sockaddr_un unx;
#endif
+#endif
} sa;
};
But maybe Yann is working on a more useful revision that allows APR apps to
take advantage of longer AF_UNIX paths? I dunno.
--
Born in Roswell... married an alien...
http://emptyhammock.com/
http://edjective.org/
Re: fix a technicality with struct sockaddr_un in 1.6.x branch???
Posted by Yann Ylavic <yl...@gmail.com>.
On Thu, Jun 19, 2014 at 8:31 PM, Yann Ylavic <yl...@gmail.com> wrote:
> On Thu, Jun 19, 2014 at 8:15 PM, Jeff Trawick <tr...@gmail.com> wrote:
>> But maybe Yann is working on a more useful revision that allows APR apps to
>> take advantage of longer AF_UNIX paths? I dunno.
>
> I'm working on a patch for trunk where sockaddr_un is already in apr_sockaddr_t.
> Actually I thought it was already the case in 1.5 and 1.6...
>
> So ++1 to merge this in 1.6 now, so that 1.6 can be made AF_UNIX
> compliant at any time (even if 1.6.0 is out before my or any other
> patch is accepted).
That's irrelevant, sockaddr_un is already in 1.6.
I have misread the patch...
Re: fix a technicality with struct sockaddr_un in 1.6.x branch???
Posted by Yann Ylavic <yl...@gmail.com>.
On Thu, Jun 19, 2014 at 8:15 PM, Jeff Trawick <tr...@gmail.com> wrote:
> But maybe Yann is working on a more useful revision that allows APR apps to
> take advantage of longer AF_UNIX paths? I dunno.
I'm working on a patch for trunk where sockaddr_un is already in apr_sockaddr_t.
Actually I thought it was already the case in 1.5 and 1.6...
So ++1 to merge this in 1.6 now, so that 1.6 can be made AF_UNIX
compliant at any time (even if 1.6.0 is out before my or any other
patch is accepted).