You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "mbaedke (via GitHub)" <gi...@apache.org> on 2024/05/16 14:21:05 UTC

[PR] OAK-10812: DocumentNodeStore#diffManyChildren(...) may produce incorr… [jackrabbit-oak]

mbaedke opened a new pull request, #1465:
URL: https://github.com/apache/jackrabbit-oak/pull/1465

   …ect results in readonly mode
   
   Added test case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-10812: DocumentNodeStore#diffManyChildren(...) may produce incorr… [jackrabbit-oak]

Posted by "mbaedke (via GitHub)" <gi...@apache.org>.
mbaedke commented on PR #1465:
URL: https://github.com/apache/jackrabbit-oak/pull/1465#issuecomment-2115387932

   Preliminary test. Please review if it makes any sense.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-10812: DocumentNodeStore#diffManyChildren(...) may produce incorr… [jackrabbit-oak]

Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli commented on PR #1465:
URL: https://github.com/apache/jackrabbit-oak/pull/1465#issuecomment-2122879506

   (maybe we could add a test case to reproduce real being different than configured id - and then the result might be two additional properties would be required, real and configured..)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-10812: DocumentNodeStore#diffManyChildren(...) may produce incorr… [jackrabbit-oak]

Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli commented on PR #1465:
URL: https://github.com/apache/jackrabbit-oak/pull/1465#issuecomment-2152945186

   PS: [commented](https://issues.apache.org/jira/browse/OAK-10812?focusedCommentId=17852849&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17852849) on the ticket


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-10812: DocumentNodeStore#diffManyChildren(...) may produce incorr… [jackrabbit-oak]

Posted by "mbaedke (via GitHub)" <gi...@apache.org>.
mbaedke commented on PR #1465:
URL: https://github.com/apache/jackrabbit-oak/pull/1465#issuecomment-2115695591

   Potential fix: if in DocumentNodeStore#getMinExternalRevisions() we replace getClusterId() - which is 0 in readonly mode - with the configured cluster id, the problem disappears.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-10812: DocumentNodeStore#diffManyChildren(...) may produce incorr… [jackrabbit-oak]

Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli commented on PR #1465:
URL: https://github.com/apache/jackrabbit-oak/pull/1465#issuecomment-2115770736

   I'm wondering if that wouldn't introduce a regression elsewhere .. there must have been a reason this was set to 0 for read-only?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-10812: DocumentNodeStore#diffManyChildren(...) may produce incorr… [jackrabbit-oak]

Posted by "mbaedke (via GitHub)" <gi...@apache.org>.
mbaedke commented on PR #1465:
URL: https://github.com/apache/jackrabbit-oak/pull/1465#issuecomment-2137187902

   @stefan-egli , see ticket for an explanation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-10812: DocumentNodeStore#diffManyChildren(...) may produce incorr… [jackrabbit-oak]

Posted by "ionutzpi (via GitHub)" <gi...@apache.org>.
ionutzpi commented on PR #1465:
URL: https://github.com/apache/jackrabbit-oak/pull/1465#issuecomment-2260674517

   @mbaedke adding a check to handle the case where fromRev.pmin(minRevisions) results in an empty vector could fix the issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-10812: DocumentNodeStore#diffManyChildren(...) may produce incorr… [jackrabbit-oak]

Posted by "mbaedke (via GitHub)" <gi...@apache.org>.
mbaedke merged PR #1465:
URL: https://github.com/apache/jackrabbit-oak/pull/1465


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-10812: DocumentNodeStore#diffManyChildren(...) may produce incorr… [jackrabbit-oak]

Posted by "mbaedke (via GitHub)" <gi...@apache.org>.
mbaedke commented on PR #1465:
URL: https://github.com/apache/jackrabbit-oak/pull/1465#issuecomment-2116946297

   @stefan-egli , I understood that it's not supposed to collide with a simultaneously running read-write node. The proposal is not to change the cluster id, but to add an additional property to store the configured cluster id.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org