You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/01/22 10:36:19 UTC
[GitHub] [iceberg] openinx opened a new pull request #2135: Flink: Support SQL 'IF EXISTS' and 'IF NOT EXISTS'
openinx opened a new pull request #2135:
URL: https://github.com/apache/iceberg/pull/2135
This will address bug from here: https://github.com/apache/iceberg/issues/2133
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #2135: Flink: Support SQL 'IF EXISTS' and 'IF NOT EXISTS'
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #2135:
URL: https://github.com/apache/iceberg/pull/2135
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] openinx commented on a change in pull request #2135: Flink: Support SQL 'IF EXISTS' and 'IF NOT EXISTS'
Posted by GitBox <gi...@apache.org>.
openinx commented on a change in pull request #2135:
URL: https://github.com/apache/iceberg/pull/2135#discussion_r562523500
##########
File path: flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogTable.java
##########
@@ -124,6 +126,25 @@ public void testCreateTable() throws TableNotExistException {
Assert.assertEquals(Maps.newHashMap(), catalogTable.getOptions());
}
+ @Ignore("Enable this after upgrade flink to 1.12.0, because it starts to support 'CREATE TABLE IF NOT EXISTS")
Review comment:
Currently, the flink 1.12.x & master branch does not provide `IF EXISTS` or `IF NOT EXISTS` for `RENAME TABLE` and `ALTER TABLE`, so I did not provide unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] openinx closed pull request #2135: Flink: Support SQL 'IF EXISTS' and 'IF NOT EXISTS'
Posted by GitBox <gi...@apache.org>.
openinx closed pull request #2135:
URL: https://github.com/apache/iceberg/pull/2135
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org