You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/10/21 02:53:13 UTC
[GitHub] [zookeeper] hanm opened a new pull request #1512: ZOOKEEPER-3967: Jetty License Update.
hanm opened a new pull request #1512:
URL: https://github.com/apache/zookeeper/pull/1512
Add license for Jetty which is used in both Admin server and ZooKeeperServerController.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on pull request #1512: ZOOKEEPER-3967: Jetty License Update.
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1512:
URL: https://github.com/apache/zookeeper/pull/1512#issuecomment-721574734
@ztzg good catch, we (@hanm indeed) recently added jetty client !
@hanm can you please update the patch ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1512: ZOOKEEPER-3967: Jetty License Update.
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1512:
URL: https://github.com/apache/zookeeper/pull/1512#issuecomment-721575129
Right; for reference, it was added by [ZOOKEEPER-3948](https://issues.apache.org/jira/browse/ZOOKEEPER-3948).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] hanm commented on pull request #1512: ZOOKEEPER-3967: Jetty License Update.
Posted by GitBox <gi...@apache.org>.
hanm commented on pull request #1512:
URL: https://github.com/apache/zookeeper/pull/1512#issuecomment-722648638
good catch, just uploaded jetty-client license. I was looking at my old target folder which does not contain the newly added jetty-client jar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on pull request #1512: ZOOKEEPER-3967: Jetty License Update.
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1512:
URL: https://github.com/apache/zookeeper/pull/1512#issuecomment-722933989
committed to master branch @hanm
if you have time please create a separate patch for branch-3.6, but without the jetty-client license
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1512: ZOOKEEPER-3967: Jetty License Update.
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1512:
URL: https://github.com/apache/zookeeper/pull/1512#issuecomment-721573905
@hanm, @eolivelli: I just had a closer look into this; it seems we are missing `jetty-client-9.4.32.v20200930.LICENSE.txt`. Should I add it as part of the merge, or am I missing something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli closed pull request #1512: ZOOKEEPER-3967: Jetty License Update.
Posted by GitBox <gi...@apache.org>.
eolivelli closed pull request #1512:
URL: https://github.com/apache/zookeeper/pull/1512
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org