You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/10/13 18:34:54 UTC

[GitHub] [incubator-ratis] Parigyan opened a new pull request #223: Revert "Revert "RATIS-672. Vagrant test's Maven 404's""

Parigyan opened a new pull request #223:
URL: https://github.com/apache/incubator-ratis/pull/223


   This reverts commit 89abd139
   
   ## What changes were proposed in this pull request?
   ./dev-support/vagrant/run_all_tests.sh build command was failing.
   There was previous patch available for the legacy issue , concerning Maven 404 response from apache mirror for maven installation.
   The fix has to do with reverting the patch to original fix, and merging the new changes with the concerned files.
   
   ## What is the link to the Apache JIRA
   https://issues.apache.org/jira/browse/RATIS-672
   
   ## How was this patch tested?
   $./dev-support/vagrant/run_all_tests.sh build , command ran successfully
   <img width="1440" alt="Screenshot 2020-10-13 at 11 57 46 PM" src="https://user-images.githubusercontent.com/6339961/95901288-bced3700-0db0-11eb-89da-ea50fd091184.png">
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] lokeshj1703 commented on pull request #223: Revert "Revert "RATIS-672. Vagrant test's Maven 404's""

Posted by GitBox <gi...@apache.org>.
lokeshj1703 commented on pull request #223:
URL: https://github.com/apache/incubator-ratis/pull/223#issuecomment-717813345


   The new Dockerfile would always require some arguments I guess. Can we give some default values to the ARG defined in the Dockerfile?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] Parigyan commented on pull request #223: Revert "Revert "RATIS-672. Vagrant test's Maven 404's""

Posted by GitBox <gi...@apache.org>.
Parigyan commented on pull request #223:
URL: https://github.com/apache/incubator-ratis/pull/223#issuecomment-718160405


   Found https://yetus.apache.org/documentation/0.12.0/RELEASENOTES/ 
   YETUS-919 was specifically created to address the issue of build failure in YETUS.
   
   add_docker_build_arg should get the work done.
   in Dockerfile the argument for protobuf is already there, and it picks the value from source /dev-support/ci/common.sh 
   but it seems in case of yetus it fails as the common.sh is not sufficient in getting executed.
   
   I'll try to use the new mechanism of passing the args for docker build in yetus.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] Parigyan edited a comment on pull request #223: Revert "Revert "RATIS-672. Vagrant test's Maven 404's""

Posted by GitBox <gi...@apache.org>.
Parigyan edited a comment on pull request #223:
URL: https://github.com/apache/incubator-ratis/pull/223#issuecomment-718160405


   Found https://yetus.apache.org/documentation/0.12.0/RELEASENOTES/ 
   YETUS-919 was specifically created to address the issue of build failure in YETUS for docker args resolution vis-a-vis ratis.
   
   _add_docker_build_arg_ should get the work done.
   In Dockerfile the argument for protobuf is already there, and it picks the value from source /dev-support/ci/common.sh 
   but it seems in case of yetus it fails as the common.sh is not sufficient in getting executed.
   
   I'll try to use the new mechanism of passing the args for docker build in yetus.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] Parigyan commented on pull request #223: Revert "Revert "RATIS-672. Vagrant test's Maven 404's""

Posted by GitBox <gi...@apache.org>.
Parigyan commented on pull request #223:
URL: https://github.com/apache/incubator-ratis/pull/223#issuecomment-718144970


   @lokeshj1703 Thanks for the feedback, I'll take a look into dockerfile build.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org