You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/07/26 14:39:00 UTC

[jira] [Commented] (PHOENIX-6519) Make SchemaTool work with lower case table and column names

    [ https://issues.apache.org/jira/browse/PHOENIX-6519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17387393#comment-17387393 ] 

ASF GitHub Bot commented on PHOENIX-6519:
-----------------------------------------

richardantal opened a new pull request #1275:
URL: https://github.com/apache/phoenix/pull/1275


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Make SchemaTool work with lower case table and column names
> -----------------------------------------------------------
>
>                 Key: PHOENIX-6519
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6519
>             Project: Phoenix
>          Issue Type: Task
>          Components: core
>            Reporter: Richárd Antal
>            Priority: Major
>
> I wrote this test as part of a PR for PHOENIX-6518 and it fails.
> {code:java}
>     @Test
>     public void testCreateTableStatementLowerCase() throws Exception {
>         String tableName = "lowecasetbl1";
>         String schemaName = "lowecaseschemaname1";
>         String pTableFullName = SchemaUtil.getEscapedTableName(schemaName, tableName);
>         String createTableStmt = "CREATE TABLE "+ pTableFullName + "(\"smallK\" VARCHAR NOT NULL PRIMARY KEY, "
>                 + "V1 VARCHAR, V2 VARCHAR) TTL=2592000, IMMUTABLE_ROWS=TRUE, DISABLE_WAL=TRUE";
>         List<String> queries = new ArrayList<String>(){};
>         queries.add(createTableStmt);
>         String result = runSchemaExtractionTool("\"" + schemaName + "\"", "\"" + tableName + "\"", null, queries);
>         Assert.assertEquals(createTableStmt, result.toUpperCase());
>     }{code}
> Expected:
> {code:java}
> CREATE TABLE "lowecaseschemaname1"."lowecasetbl1"("smallK" VARCHAR NOT NULL PRIMARY KEY, V1 VARCHAR, V2 VARCHAR) TTL=2592000, IMMUTABLE_ROWS=TRUE, DISABLE_WAL=TRUE{code}
> Actual result:
> {code:java}
> CREATE TABLE LOWECASESCHEMANAME1.LOWECASETBL1(SMALLK VARCHAR NOT NULL PRIMARY KEY, V1 VARCHAR, V2 VARCHAR) TTL=2592000, IMMUTABLE_ROWS=TRUE, DISABLE_WAL=TRUE{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)