[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9043: feat: add nacos metadata suport, for customize balancer

["monkeyDluffy6017 (via GitHub)" <gi...@apache.org>]

monkeyDluffy6017 commented on code in PR #9043:
URL: https://github.com/apache/apisix/pull/9043#discussion_r1131866661


##########
apisix/discovery/nacos/init.lua:
##########
@@ -315,6 +315,7 @@ local function fetch_full_registry(premature)
                 host = host.ip,
                 port = host.port,
                 weight = host.weight or default_weight,
+                metadata = host.metadata or {},

Review Comment:
   Why the default value is an empty table, is nil more appropriate?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org