[GitHub] [iceberg] CircArgs commented on a change in pull request #3965: implement __eq__ for iceberg type classes.

[GitBox <gi...@apache.org>]

CircArgs commented on a change in pull request #3965:
URL: https://github.com/apache/iceberg/pull/3965#discussion_r796048880



##########
File path: python/src/iceberg/types.py
##########
@@ -46,6 +46,9 @@ def __repr__(self):
     def __str__(self):
         return self._type_string
 
+    def __eq__(self, other):

Review comment:
       @rdblue Thanks for drawing me to this. I think using `__new__` is a great idea you've mentioned a few times elsewhere. It also solved issues with the generics I was trying to make because the syntax is very vague especially for nested fields without any named arguments. I've been working on something since we spoke I've had sitting this morning. @jun-he this seems quite similar https://github.com/apache/iceberg/pull/4016. would definitely be interested in collaborating on this




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org