You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/12/23 13:00:31 UTC

[GitHub] [shardingsphere] lwtdev opened a new pull request #8740: Add condition expression assertion for ExpectedJoinTable #7880.

lwtdev opened a new pull request #8740:
URL: https://github.com/apache/shardingsphere/pull/8740


   Fixes #7880.
   
   Changes proposed in this pull request:
   
     * Add `condition` and `columns` assertions for `ExpectedJoinTable`.
     * Adjust the old test case, replace joinSpecification with condition or columns in `join-table`.
     * Delete unused expected jaxb classes(such as `ExpectedJoinSpecification.java`, `ExpectedAndPredicate.java`).
     * Rename `impl.expr` to `impl.expression`.
     * Move `ExpectedWhereClause.java` from `impl.predicate` to `impl.where`.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] lwtdev edited a comment on pull request #8740: Add condition expression assertion for ExpectedJoinTable.

Posted by GitBox <gi...@apache.org>.
lwtdev edited a comment on pull request #8740:
URL: https://github.com/apache/shardingsphere/pull/8740#issuecomment-750354646


   > It is unnecessary to change the package name, can you revert that?
   
   @terrymanu 
   
   Rename `impl.expr` to `impl.expression` is in order to be consistent with the name under `asserts.segment` (`org.apache.shardingsphere.test.sql.parser.parameterized.asserts.segment.expression`).
   
   Maybe I can rename `asserts.segment.expression` to `asserts.segment.expr`?
    `ExpressionSegment` is under package `org.apache.shardingsphere.sql.parser.sql.common.segment.dml.expr`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io commented on pull request #8740: Add condition expression assertion for ExpectedJoinTable.

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #8740:
URL: https://github.com/apache/shardingsphere/pull/8740#issuecomment-750749863


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8740?src=pr&el=h1) Report
   > Merging [#8740](https://codecov.io/gh/apache/shardingsphere/pull/8740?src=pr&el=desc) (772c42d) into [master](https://codecov.io/gh/apache/shardingsphere/commit/aa0ba616298b75034ac62776e43b066a57d97731?el=desc) (aa0ba61) will **decrease** coverage by `0.17%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/8740/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/8740?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #8740      +/-   ##
   ============================================
   - Coverage     71.09%   70.91%   -0.18%     
   + Complexity      625      624       -1     
   ============================================
     Files          1592     1597       +5     
     Lines         25354    25405      +51     
     Branches       4431     4440       +9     
   ============================================
   - Hits          18025    18017       -8     
   - Misses         6137     6195      +58     
   - Partials       1192     1193       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8740?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...end/text/distsql/rdl/RDLBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/8740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL1JETEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh) | `80.00% <0.00%> (-8.89%)` | `0.00% <0.00%> (ø%)` | |
   | [.../sql/parser/mysql/visitor/MySQLSQLStatVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/8740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9teXNxbC92aXNpdG9yL015U1FMU1FMU3RhdFZpc2l0b3IuamF2YQ==) | `46.00% <0.00%> (-4.91%)` | `0.00% <0.00%> (ø%)` | |
   | [...or/statement/impl/MySQLDDLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/8740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9teXNxbC92aXNpdG9yL3N0YXRlbWVudC9pbXBsL015U1FMRERMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `44.11% <0.00%> (-0.41%)` | `1.00% <0.00%> (ø%)` | |
   | [...java/org/apache/shardingsphere/ha/rule/HARule.java](https://codecov.io/gh/apache/shardingsphere/pull/8740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtaGEvc2hhcmRpbmdzcGhlcmUtaGEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9oYS9ydWxlL0hBUnVsZS5qYXZh) | `54.23% <0.00%> (-0.31%)` | `0.00% <0.00%> (ø%)` | |
   | [...re/agent/core/plugin/loader/AgentPluginLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/8740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9wbHVnaW4vbG9hZGVyL0FnZW50UGx1Z2luTG9hZGVyLmphdmE=) | `13.33% <0.00%> (-0.13%)` | `0.00% <0.00%> (ø%)` | |
   | [...sitor/statement/impl/MySQLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/8740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9teXNxbC92aXNpdG9yL3N0YXRlbWVudC9pbXBsL015U1FMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `79.93% <0.00%> (-0.07%)` | `1.00% <0.00%> (ø%)` | |
   | [...va/org/apache/shardingsphere/ha/mgr/MGRHAType.java](https://codecov.io/gh/apache/shardingsphere/pull/8740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtaGEvc2hhcmRpbmdzcGhlcmUtaGEtbWdyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9oYS9tZ3IvTUdSSEFUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...gsphere/agent/core/plugin/service/BootService.java](https://codecov.io/gh/apache/shardingsphere/pull/8740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9wbHVnaW4vc2VydmljZS9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...e/agent/core/config/JaegerPluginConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/8740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jb25maWcvSmFlZ2VyUGx1Z2luQ29uZmlndXJhdGlvbi5qYXZh) | `83.33% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...e/agent/core/config/ZipkinPluginConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/8740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jb25maWcvWmlwa2luUGx1Z2luQ29uZmlndXJhdGlvbi5qYXZh) | `80.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | ... and [42 more](https://codecov.io/gh/apache/shardingsphere/pull/8740/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8740?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8740?src=pr&el=footer). Last update [aa0ba61...772c42d](https://codecov.io/gh/apache/shardingsphere/pull/8740?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #8740: Add condition expression assertion for ExpectedJoinTable.

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #8740:
URL: https://github.com/apache/shardingsphere/pull/8740


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] lwtdev commented on a change in pull request #8740: Add condition expression assertion for ExpectedJoinTable.

Posted by GitBox <gi...@apache.org>.
lwtdev commented on a change in pull request #8740:
URL: https://github.com/apache/shardingsphere/pull/8740#discussion_r548780208



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/jaxb/cases/domain/segment/impl/table/ExpectedJoinTable.java
##########
@@ -20,23 +20,29 @@
 import lombok.Getter;
 import lombok.Setter;
 import org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.segment.AbstractExpectedDelimiterSQLSegment;
-import org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.segment.impl.ExpectedJoinSpecification;
+import org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.segment.impl.column.ExpectedColumn;
+import org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.segment.impl.expr.ExpectedExpression;
 
 import javax.xml.bind.annotation.XmlElement;
+import java.util.LinkedList;
+import java.util.List;
 
 /**
  * Expected JoinTable.
  */
 @Getter
 @Setter
 public final class ExpectedJoinTable extends AbstractExpectedDelimiterSQLSegment {
-    
+
     @XmlElement(name = "left")
     private ExpectedTable left;
 
     @XmlElement(name = "right")
     private ExpectedTable right;
-    
-    @XmlElement
-    private ExpectedJoinSpecification joinSpecification;
+
+    @XmlElement(name = "condition")
+    private ExpectedExpression condition;
+
+    @XmlElement(name = "columns")
+    private final List<ExpectedColumn> columns = new LinkedList<>();

Review comment:
       @jingshanglu OK, I will modify it. What about `condition`, do we should rename it to `on-condition`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] lwtdev commented on pull request #8740: Add condition expression assertion for ExpectedJoinTable.

Posted by GitBox <gi...@apache.org>.
lwtdev commented on pull request #8740:
URL: https://github.com/apache/shardingsphere/pull/8740#issuecomment-750354646


   > It is unnecessary to change the package name, can you revert that?
   
   @terrymanu 
   
   Rename `expr` to `expression` is in order to be consistent with the name under `asserts.segment` (`org.apache.shardingsphere.test.sql.parser.parameterized.asserts.segment.expression`).
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] jingshanglu commented on a change in pull request #8740: Add condition expression assertion for ExpectedJoinTable.

Posted by GitBox <gi...@apache.org>.
jingshanglu commented on a change in pull request #8740:
URL: https://github.com/apache/shardingsphere/pull/8740#discussion_r548780754



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/jaxb/cases/domain/segment/impl/table/ExpectedJoinTable.java
##########
@@ -20,23 +20,29 @@
 import lombok.Getter;
 import lombok.Setter;
 import org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.segment.AbstractExpectedDelimiterSQLSegment;
-import org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.segment.impl.ExpectedJoinSpecification;
+import org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.segment.impl.column.ExpectedColumn;
+import org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.segment.impl.expr.ExpectedExpression;
 
 import javax.xml.bind.annotation.XmlElement;
+import java.util.LinkedList;
+import java.util.List;
 
 /**
  * Expected JoinTable.
  */
 @Getter
 @Setter
 public final class ExpectedJoinTable extends AbstractExpectedDelimiterSQLSegment {
-    
+
     @XmlElement(name = "left")
     private ExpectedTable left;
 
     @XmlElement(name = "right")
     private ExpectedTable right;
-    
-    @XmlElement
-    private ExpectedJoinSpecification joinSpecification;
+
+    @XmlElement(name = "condition")
+    private ExpectedExpression condition;
+
+    @XmlElement(name = "columns")
+    private final List<ExpectedColumn> columns = new LinkedList<>();

Review comment:
       @lwtdev I think both will do.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] jingshanglu edited a comment on pull request #8740: Add condition expression assertion for ExpectedJoinTable.

Posted by GitBox <gi...@apache.org>.
jingshanglu edited a comment on pull request #8740:
URL: https://github.com/apache/shardingsphere/pull/8740#issuecomment-751188415


   > It is unnecessary to change the package name, can you revert that?
   
   @terrymanu It is a `change request` review,  you need merge the pr.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] jingshanglu commented on pull request #8740: Add condition expression assertion for ExpectedJoinTable.

Posted by GitBox <gi...@apache.org>.
jingshanglu commented on pull request #8740:
URL: https://github.com/apache/shardingsphere/pull/8740#issuecomment-751188415


   > It is unnecessary to change the package name, can you revert that?
   
   @terrymanu It is a `change request` review, need you merge the pr.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] jingshanglu commented on a change in pull request #8740: Add condition expression assertion for ExpectedJoinTable.

Posted by GitBox <gi...@apache.org>.
jingshanglu commented on a change in pull request #8740:
URL: https://github.com/apache/shardingsphere/pull/8740#discussion_r548778885



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/jaxb/cases/domain/segment/impl/table/ExpectedJoinTable.java
##########
@@ -20,23 +20,29 @@
 import lombok.Getter;
 import lombok.Setter;
 import org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.segment.AbstractExpectedDelimiterSQLSegment;
-import org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.segment.impl.ExpectedJoinSpecification;
+import org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.segment.impl.column.ExpectedColumn;
+import org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.segment.impl.expr.ExpectedExpression;
 
 import javax.xml.bind.annotation.XmlElement;
+import java.util.LinkedList;
+import java.util.List;
 
 /**
  * Expected JoinTable.
  */
 @Getter
 @Setter
 public final class ExpectedJoinTable extends AbstractExpectedDelimiterSQLSegment {
-    
+
     @XmlElement(name = "left")
     private ExpectedTable left;
 
     @XmlElement(name = "right")
     private ExpectedTable right;
-    
-    @XmlElement
-    private ExpectedJoinSpecification joinSpecification;
+
+    @XmlElement(name = "condition")
+    private ExpectedExpression condition;
+
+    @XmlElement(name = "columns")
+    private final List<ExpectedColumn> columns = new LinkedList<>();

Review comment:
       @lwtdev Maybe it is better to rename `columns` to `using-columns`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io edited a comment on pull request #8740: Add condition expression assertion for ExpectedJoinTable.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #8740:
URL: https://github.com/apache/shardingsphere/pull/8740#issuecomment-750749863


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8740?src=pr&el=h1) Report
   > Merging [#8740](https://codecov.io/gh/apache/shardingsphere/pull/8740?src=pr&el=desc) (772c42d) into [master](https://codecov.io/gh/apache/shardingsphere/commit/aa0ba616298b75034ac62776e43b066a57d97731?el=desc) (aa0ba61) will **decrease** coverage by `0.17%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/8740/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/8740?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #8740      +/-   ##
   ============================================
   - Coverage     71.09%   70.91%   -0.18%     
   + Complexity      625      624       -1     
   ============================================
     Files          1592     1597       +5     
     Lines         25354    25405      +51     
     Branches       4431     4440       +9     
   ============================================
   - Hits          18025    18017       -8     
   - Misses         6137     6195      +58     
   - Partials       1192     1193       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8740?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...end/text/distsql/rdl/RDLBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/8740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL1JETEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh) | `80.00% <0.00%> (-8.89%)` | `0.00% <0.00%> (ø%)` | |
   | [.../sql/parser/mysql/visitor/MySQLSQLStatVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/8740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9teXNxbC92aXNpdG9yL015U1FMU1FMU3RhdFZpc2l0b3IuamF2YQ==) | `46.00% <0.00%> (-4.91%)` | `0.00% <0.00%> (ø%)` | |
   | [...or/statement/impl/MySQLDDLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/8740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9teXNxbC92aXNpdG9yL3N0YXRlbWVudC9pbXBsL015U1FMRERMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `44.11% <0.00%> (-0.41%)` | `1.00% <0.00%> (ø%)` | |
   | [...java/org/apache/shardingsphere/ha/rule/HARule.java](https://codecov.io/gh/apache/shardingsphere/pull/8740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtaGEvc2hhcmRpbmdzcGhlcmUtaGEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9oYS9ydWxlL0hBUnVsZS5qYXZh) | `54.23% <0.00%> (-0.31%)` | `0.00% <0.00%> (ø%)` | |
   | [...re/agent/core/plugin/loader/AgentPluginLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/8740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9wbHVnaW4vbG9hZGVyL0FnZW50UGx1Z2luTG9hZGVyLmphdmE=) | `13.33% <0.00%> (-0.13%)` | `0.00% <0.00%> (ø%)` | |
   | [...sitor/statement/impl/MySQLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/8740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9teXNxbC92aXNpdG9yL3N0YXRlbWVudC9pbXBsL015U1FMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `79.93% <0.00%> (-0.07%)` | `1.00% <0.00%> (ø%)` | |
   | [...va/org/apache/shardingsphere/ha/mgr/MGRHAType.java](https://codecov.io/gh/apache/shardingsphere/pull/8740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtaGEvc2hhcmRpbmdzcGhlcmUtaGEtbWdyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9oYS9tZ3IvTUdSSEFUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...gsphere/agent/core/plugin/service/BootService.java](https://codecov.io/gh/apache/shardingsphere/pull/8740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9wbHVnaW4vc2VydmljZS9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...e/agent/core/config/JaegerPluginConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/8740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jb25maWcvSmFlZ2VyUGx1Z2luQ29uZmlndXJhdGlvbi5qYXZh) | `83.33% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...e/agent/core/config/ZipkinPluginConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/8740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jb25maWcvWmlwa2luUGx1Z2luQ29uZmlndXJhdGlvbi5qYXZh) | `80.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | ... and [42 more](https://codecov.io/gh/apache/shardingsphere/pull/8740/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8740?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8740?src=pr&el=footer). Last update [aa0ba61...772c42d](https://codecov.io/gh/apache/shardingsphere/pull/8740?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on pull request #8740: Add condition expression assertion for ExpectedJoinTable.

Posted by GitBox <gi...@apache.org>.
terrymanu commented on pull request #8740:
URL: https://github.com/apache/shardingsphere/pull/8740#issuecomment-750765126


   > > It is unnecessary to change the package name, can you revert that?
   > 
   > @terrymanu
   > 
   > Rename `impl.expr` to `impl.expression` is in order to be consistent with the name under `asserts.segment` (`org.apache.shardingsphere.test.sql.parser.parameterized.asserts.segment.expression`).
   > 
   > Maybe I should rename `asserts.segment.expression` to `asserts.segment.expr`?
   > Becasue `ExpressionSegment` is under package `org.apache.shardingsphere.sql.parser.sql.common.segment.dml.expr`.
   
   If rename is necessary, it is better to split them to another pr.
   It is easy to review if one pr do one thing only.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] lwtdev edited a comment on pull request #8740: Add condition expression assertion for ExpectedJoinTable.

Posted by GitBox <gi...@apache.org>.
lwtdev edited a comment on pull request #8740:
URL: https://github.com/apache/shardingsphere/pull/8740#issuecomment-750354646


   > It is unnecessary to change the package name, can you revert that?
   
   @terrymanu 
   
   Rename `impl.expr` to `impl.expression` is in order to be consistent with the name under `asserts.segment` (`org.apache.shardingsphere.test.sql.parser.parameterized.asserts.segment.expression`).
   
   Maybe I should rename `asserts.segment.expression` to `asserts.segment.expr`?
   Becasue `ExpressionSegment` is under package `org.apache.shardingsphere.sql.parser.sql.common.segment.dml.expr`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] lwtdev commented on pull request #8740: Add condition expression assertion for ExpectedJoinTable.

Posted by GitBox <gi...@apache.org>.
lwtdev commented on pull request #8740:
URL: https://github.com/apache/shardingsphere/pull/8740#issuecomment-750779701


   > > > It is unnecessary to change the package name, can you revert that?
   > > 
   > > 
   > > @terrymanu
   > > Rename `impl.expr` to `impl.expression` is in order to be consistent with the name under `asserts.segment` (`org.apache.shardingsphere.test.sql.parser.parameterized.asserts.segment.expression`).
   > > Maybe I should rename `asserts.segment.expression` to `asserts.segment.expr`?
   > > Becasue `ExpressionSegment` is under package `org.apache.shardingsphere.sql.parser.sql.common.segment.dml.expr`.
   > 
   > If rename is necessary, it is better to split them to another pr.
   > It is easy to review if one pr do one thing only.
   
   I will revert it~


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org