You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Russ Garrett (JIRA)" <ji...@apache.org> on 2009/05/12 18:17:45 UTC
[jira] Created: (THRIFT-499) Thrift_protocol PHP extension does not
handle signedness correctly
Thrift_protocol PHP extension does not handle signedness correctly
------------------------------------------------------------------
Key: THRIFT-499
URL: https://issues.apache.org/jira/browse/THRIFT-499
Project: Thrift
Issue Type: Bug
Components: Library (PHP)
Reporter: Russ Garrett
The PHP Thrift protocol extension does not correctly unserialize integers - it assumes they're unsigned, but all integers in Thrift are signed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-499) Thrift_protocol PHP extension does
not handle signedness correctly
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury resolved THRIFT-499.
----------------------------------
Resolution: Fixed
Fix Version/s: 0.2
Assignee: Russ Garrett
This patch is hyper simple, so I just committed it. Thanks for the patch, Russ!
> Thrift_protocol PHP extension does not handle signedness correctly
> ------------------------------------------------------------------
>
> Key: THRIFT-499
> URL: https://issues.apache.org/jira/browse/THRIFT-499
> Project: Thrift
> Issue Type: Bug
> Components: Library (PHP)
> Reporter: Russ Garrett
> Assignee: Russ Garrett
> Fix For: 0.2
>
> Attachments: thrift_protocol_signedness.patch, thrift_protocol_signedness.patch
>
>
> The PHP Thrift protocol extension does not correctly unserialize integers - it assumes they're unsigned, but all integers in Thrift are signed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-499) Thrift_protocol PHP extension does not
handle signedness correctly
Posted by "Russ Garrett (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Russ Garrett updated THRIFT-499:
--------------------------------
Attachment: thrift_protocol_signedness.patch
Attached patch fixes this bug.
> Thrift_protocol PHP extension does not handle signedness correctly
> ------------------------------------------------------------------
>
> Key: THRIFT-499
> URL: https://issues.apache.org/jira/browse/THRIFT-499
> Project: Thrift
> Issue Type: Bug
> Components: Library (PHP)
> Reporter: Russ Garrett
> Attachments: thrift_protocol_signedness.patch
>
>
> The PHP Thrift protocol extension does not correctly unserialize integers - it assumes they're unsigned, but all integers in Thrift are signed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-499) Thrift_protocol PHP extension does not
handle signedness correctly
Posted by "Russ Garrett (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Russ Garrett updated THRIFT-499:
--------------------------------
Attachment: thrift_protocol_signedness.patch
Patch relative to project root.
> Thrift_protocol PHP extension does not handle signedness correctly
> ------------------------------------------------------------------
>
> Key: THRIFT-499
> URL: https://issues.apache.org/jira/browse/THRIFT-499
> Project: Thrift
> Issue Type: Bug
> Components: Library (PHP)
> Reporter: Russ Garrett
> Attachments: thrift_protocol_signedness.patch, thrift_protocol_signedness.patch
>
>
> The PHP Thrift protocol extension does not correctly unserialize integers - it assumes they're unsigned, but all integers in Thrift are signed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.