[GitHub] [arrow] thisisnic commented on a diff in pull request #12790: ARROW-16011: [R] CI jobs should fail if lintr picked up issues

[GitBox <gi...@apache.org>]

thisisnic commented on code in PR #12790:
URL: https://github.com/apache/arrow/pull/12790#discussion_r842736093


##########
r/tests/testthat/test-style.R:
##########
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+test_that("Package is lint free", {
+    skip_on_cran()
+    skip_if_not_installed("lintr")
+    lintr::expect_lint_free()

Review Comment:
   Nice, I didn't know this function existed before now!



##########
.github/workflows/r.yml:
##########
@@ -144,7 +144,7 @@ jobs:
           # Don't set a TZ here to test that case. These builds will have the following warning in them:
           #   System has not been booted with systemd as init system (PID 1). Can't operate.
           #   Failed to connect to bus: Host is down
-          archery docker run -e TZ="" r
+          archery docker run -e TZ="" -e GITHUB_ACTIONS="true" r

Review Comment:
   Please can you just remind me what this does?



##########
.github/workflows/r.yml:
##########
@@ -248,6 +248,7 @@ jobs:
     env:
       ARROW_R_CXXFLAGS: "-Werror"
       _R_CHECK_TESTS_NLINES_: 0
+      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN}}

Review Comment:
   Now you're using a different method to the one I started, is this line still needed?



##########
r/R/array-data.R:
##########
@@ -44,7 +44,7 @@
 ArrayData <- R6Class("ArrayData",
   inherit = ArrowObject,
   active = list(
-    type = function() ArrayData__get_type(self),
+    type =function() ArrayData__get_type(self),

Review Comment:
   Just adding a comment here to remind us to remove this once the PR is ready to be approved



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org