[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #8076: event logging changes

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #8076: event logging changes
URL: https://github.com/apache/incubator-superset/pull/8076#discussion_r315895596
 
 

 ##########
 File path: superset/utils/event_logger.py
 ##########
 @@ -22,17 +22,77 @@
 import json
 import logging
 import textwrap
-from typing import Any, cast, Type
+import time
+from typing import Any, cast, List, Type
 
-from flask import current_app, g, request
+from flask import current_app, g, request, Response
+
+SUPERSET_EVENT_LOGGER_NAME = "superset_events"
+
+
+class SupersetEvent(object):
 
 Review comment:
   NIT: deriving `object` is an "out-of-fashion" py2 best practice, not needed anymore in py3

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org