You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Stephan Huttenhuis (JIRA)" <ji...@apache.org> on 2010/04/02 16:46:28 UTC

[jira] Created: (JCR-2591) Prevent single-valued property with no value after RTE

Prevent single-valued property with no value after RTE
------------------------------------------------------

                 Key: JCR-2591
                 URL: https://issues.apache.org/jira/browse/JCR-2591
             Project: Jackrabbit Content Repository
          Issue Type: Improvement
          Components: jackrabbit-core
    Affects Versions: 1.6.1
            Reporter: Stephan Huttenhuis


In NodeImpl a newly created property is removed when a checked RepositoryException occurs when setting the value. But if a RuntimeException occurs it is not removed again. It is better to remove it always if settings the value was unsuccessful.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-2591) Prevent single-valued property with no value after RTE

Posted by "Stephan Huttenhuis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stephan Huttenhuis updated JCR-2591:
------------------------------------

    Attachment: JCR-2591.patch

> Prevent single-valued property with no value after RTE
> ------------------------------------------------------
>
>                 Key: JCR-2591
>                 URL: https://issues.apache.org/jira/browse/JCR-2591
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>    Affects Versions: 1.6.1
>            Reporter: Stephan Huttenhuis
>         Attachments: JCR-2591.patch
>
>
> In NodeImpl a newly created property is removed when a checked RepositoryException occurs when setting the value. But if a RuntimeException occurs it is not removed again. It is better to remove it always if settings the value was unsuccessful.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-2591) Prevent single-valued property with no value after RTE

Posted by "Stephan Huttenhuis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stephan Huttenhuis updated JCR-2591:
------------------------------------

    Status: Patch Available  (was: Open)

Attached patch

> Prevent single-valued property with no value after RTE
> ------------------------------------------------------
>
>                 Key: JCR-2591
>                 URL: https://issues.apache.org/jira/browse/JCR-2591
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>    Affects Versions: 1.6.1
>            Reporter: Stephan Huttenhuis
>
> In NodeImpl a newly created property is removed when a checked RepositoryException occurs when setting the value. But if a RuntimeException occurs it is not removed again. It is better to remove it always if settings the value was unsuccessful.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JCR-2591) Prevent single-valued property with no value after RTE

Posted by "Stephan Huttenhuis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858479#action_12858479 ] 

Stephan Huttenhuis commented on JCR-2591:
-----------------------------------------

We had some problems with null single-value properties, which are not allowed according to JSR-170. 

No RuntimeExceptions should be thrown, but theoretically NullPointerExceptions can be thrown which may cause a null single-value property. Unfortunately I have no concrete case.

> Prevent single-valued property with no value after RTE
> ------------------------------------------------------
>
>                 Key: JCR-2591
>                 URL: https://issues.apache.org/jira/browse/JCR-2591
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>    Affects Versions: 1.6.1
>            Reporter: Stephan Huttenhuis
>         Attachments: JCR-2591.patch
>
>
> In NodeImpl a newly created property is removed when a checked RepositoryException occurs when setting the value. But if a RuntimeException occurs it is not removed again. It is better to remove it always if settings the value was unsuccessful.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JCR-2591) Prevent single-valued property with no value after RTE

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855868#action_12855868 ] 

Jukka Zitting commented on JCR-2591:
------------------------------------

Do we have cases where this is needed? AFAIUI none of the relevant code paths should be throwing RTEs.

> Prevent single-valued property with no value after RTE
> ------------------------------------------------------
>
>                 Key: JCR-2591
>                 URL: https://issues.apache.org/jira/browse/JCR-2591
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>    Affects Versions: 1.6.1
>            Reporter: Stephan Huttenhuis
>         Attachments: JCR-2591.patch
>
>
> In NodeImpl a newly created property is removed when a checked RepositoryException occurs when setting the value. But if a RuntimeException occurs it is not removed again. It is better to remove it always if settings the value was unsuccessful.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira