You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/07/19 17:16:51 UTC

[GitHub] [airflow] potiuk commented on pull request #32692: plugins: load plugins from providers

potiuk commented on PR #32692:
URL: https://github.com/apache/airflow/pull/32692#issuecomment-1642463867

   Oh yeah. Good point. I briefly looked at it - looks like the right direction  - I think there is a bit of a problem of where the plugins are loaded from during tests as some tests expect to load plugins from "example_dags/plugins" and I think this PR removes that  path somehow,
   
   It's going to be much clearer and more straightforward after #32669 will be merged, because one of the things it does is that it unifies the unit test (local venv) / and CI  environment for tesst so that it is configured in one place only and dynamically loaded via pytest fixture from here:
   
   https://github.com/apache/airflow/pull/32669/files#diff-1748727a9777b78ae8c17034fa1c5d4a4fd38de8ce986ef13e6531b347f65588R41
   
   So it might be a wise thing to wait after #32669 is merged, rebase and try to fix it there (happy to help/brainstorm - I got quite a bit more familiar with how unit test configuration is loaded by implementing the PRs)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org