You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2022/04/14 13:58:49 UTC
[GitHub] [phoenix] stoty opened a new pull request, #1415: PHOENIX-6686 Update jackson to 2.12.6.1
stoty opened a new pull request, #1415:
URL: https://github.com/apache/phoenix/pull/1415
also switch to using jackson-bom for version version management
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1415: PHOENIX-6686 Update jackson to 2.12.6.1
Posted by GitBox <gi...@apache.org>.
stoty commented on PR #1415:
URL: https://github.com/apache/phoenix/pull/1415#issuecomment-1099860336
The only side effect is that importing the bom overrides the versions for
the
_com.fasterxml.jackson.module:jackson-module-jaxb-annotations_ and
_com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider_
artifacts pulled in by in _org.apache.hadoop:hadoop-mapreduce-client-core_,
and those new versions in turn pull in the new _jakarta.xml.bind:jakarta.xml.bind-api_ and jakarta.activation:jakarta.activation-api artifacts.
I don't expect that overriding the artifacts in Hadoop would be a problem, we're already overriding plenty of Hadoop/HBase dependency versions, and the test suite was successful
(even though the postback to PR didn't work )
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/view/change-requests/job/PR-1415/2/consoleFull
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] gjacoby126 commented on pull request #1415: PHOENIX-6686 Update jackson to 2.12.6.1
Posted by GitBox <gi...@apache.org>.
gjacoby126 commented on PR #1415:
URL: https://github.com/apache/phoenix/pull/1415#issuecomment-1099612238
@stoty - On the one hand, just taking in the bom simplifies the pom and guarantees that the different jackson subprojects will always be compatible with each other. On the other hand, that adds quite a few transitive dependencies we didn't formerly have by taking everything jackson does, correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1415: PHOENIX-6686 Update jackson to 2.12.6.1
Posted by GitBox <gi...@apache.org>.
stoty commented on PR #1415:
URL: https://github.com/apache/phoenix/pull/1415#issuecomment-1099850610
No @gjacoby126 , it only imports the dependecyManagement entries for the jackson components.
The
`<scope>import</scope>
<type>pom</type>`
does the trick.
(It's the first time see this maven feature used)
I'm attaching the old and new dependency tree to the ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty closed pull request #1415: PHOENIX-6686 Update jackson to 2.12.6.1
Posted by GitBox <gi...@apache.org>.
stoty closed pull request #1415: PHOENIX-6686 Update jackson to 2.12.6.1
URL: https://github.com/apache/phoenix/pull/1415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org