[PR] Migrate framework JUnit3 integration tests to JUnit5 (Jupiter) [ofbiz-framework]

["ashishvijaywargiya (via GitHub)" <gi...@apache.org>]

ashishvijaywargiya opened a new pull request, #1542:
URL: https://github.com/apache/ofbiz-framework/pull/1542

   I took care of the following work:
   
   1) Migrated all 20 testdef-wired JUnit3 test classes across base, common, entity, minilang, rest-api, service, webapp, and widget to Jupiter: extends OFBizTestCase/EntityTestCase -> implements JupiterTestHelper, @JunitJupiterTest on the class, @Test (+ @Order matching declaration order for multi-method files) on each method, testdef <junit-test-suite> -> <jupiter-test-suite>.
   
   2) Moved every migrated file still under src/main/{java,groovy} to src/test/{java,groovy} (common: 1 file, entity: 4, minilang: 1, rest-api: 1, service: 8, widget: 1).
   
   3) Reordered JUnit3-style message-first assertEquals/assertTrue/ assertFalse/assertNotNull/assertNull calls to JUnit 5's message-last convention across every converted file (highest volume in EntityTestSuite: 150 of 159 call sites).
   
   4) Dropped 3 dead no-op setUp()/tearDown() overrides (GroovyDslServiceEngineTests, ServiceEngineTests,
   ServiceEntityAutoTests).
   
   5) Left service/ServiceSOAPTests.java's testdef entry commented out (pre-existing, disabled before this work) - converted the class for consistency but it stays unwired, out of scope to re-enable.
   
   6) Verified every migrated suite via scoped and full testIntegration runs, all passing with 0 failures/errors.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Migrate framework JUnit3 integration tests to JUnit5 (Jupiter) [ofbiz-framework]

["ashishvijaywargiya (via GitHub)" <gi...@apache.org>]

ashishvijaywargiya merged PR #1542:
URL: https://github.com/apache/ofbiz-framework/pull/1542


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org