You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/03/06 13:07:50 UTC
[GitHub] [nifi] ottobackwards opened a new pull request #4116: NIFI-7063 add validator for lists that ensure the element validator is called f…
ottobackwards opened a new pull request #4116: NIFI-7063 add validator for lists that ensure the element validator is called f…
URL: https://github.com/apache/nifi/pull/4116
…or empty entries
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
_Enables X functionality; fixes bug NIFI-YYYY._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [x] Have you written or updated unit tests to verify your changes?
- [x] Have you verified that the full build is successful on both JDK 8 and JDK 11?
- [-] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [-] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [-] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [-] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [-] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] ottobackwards commented on issue #4116: NIFI-7063 add validator for lists that ensure the element validator is called f…
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on issue #4116: NIFI-7063 add validator for lists that ensure the element validator is called f…
URL: https://github.com/apache/nifi/pull/4116#issuecomment-607863819
Thanks @mattyb149!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] mattyb149 closed pull request #4116: NIFI-7063 add validator for lists that ensure the element validator is called f…
Posted by GitBox <gi...@apache.org>.
mattyb149 closed pull request #4116: NIFI-7063 add validator for lists that ensure the element validator is called f…
URL: https://github.com/apache/nifi/pull/4116
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] ottobackwards commented on issue #4116: NIFI-7063 add validator for lists that ensure the element validator is called f…
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on issue #4116: NIFI-7063 add validator for lists that ensure the element validator is called f…
URL: https://github.com/apache/nifi/pull/4116#issuecomment-595832072
I obviously just recreated the current test coverage from the existing listValidator, but adjusted for the new results based on the empty items getting passed or not.
I did consider refactoring all the test code to avoid duplication, but in the end I did not, as I was thinking that separate tests, with specific contextual comments would be better, even with some level of duplication.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] mattyb149 commented on issue #4116: NIFI-7063 add validator for lists that ensure the element validator is called f…
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on issue #4116: NIFI-7063 add validator for lists that ensure the element validator is called f…
URL: https://github.com/apache/nifi/pull/4116#issuecomment-607847855
+1 LGTM, ran contrib-checks, verified existing behavior is preserved by default. Thanks for the improvement! Merging to master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services