You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Chug Rolke <cr...@redhat.com> on 2012/09/06 22:48:05 UTC
Review Request: Qpid Windows + SSL = Broker and Client memory leaks + Client
hang on broker close
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6948/
-----------------------------------------------------------
Review request for qpid, Andrew Stitcher and Steve Huston.
Description
-------
Based on original work by Kerry Bonin in QPID-4257. The Windows SslConnector fails to properly relay connection events causing memory leaks and client hangs.
With this patch the memory leaks are improved and clients doing fetch(FOREVER) are woken properly.
This addresses bug QPID-4257.
https://issues.apache.org/jira/browse/QPID-4257
Diffs
-----
trunk/qpid/cpp/src/qpid/client/windows/SslConnector.cpp 1381603
Diff: https://reviews.apache.org/r/6948/diff/
Testing
-------
Thanks,
Chug Rolke
Re: Review Request: Qpid Windows + SSL = Broker and Client memory leaks +
Client hang on broker close
Posted by Andrew Stitcher <as...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6948/#review11136
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Stitcher
On Sept. 6, 2012, 8:48 p.m., Chug Rolke wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6948/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2012, 8:48 p.m.)
>
>
> Review request for qpid, Andrew Stitcher and Steve Huston.
>
>
> Description
> -------
>
> Based on original work by Kerry Bonin in QPID-4257. The Windows SslConnector fails to properly relay connection events causing memory leaks and client hangs.
> With this patch the memory leaks are improved and clients doing fetch(FOREVER) are woken properly.
>
>
> This addresses bug QPID-4257.
> https://issues.apache.org/jira/browse/QPID-4257
>
>
> Diffs
> -----
>
> trunk/qpid/cpp/src/qpid/client/windows/SslConnector.cpp 1381603
>
> Diff: https://reviews.apache.org/r/6948/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chug Rolke
>
>
Re: Review Request: Qpid Windows + SSL = Broker and Client memory leaks +
Client hang on broker close
Posted by Steve Huston <sh...@riverace.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6948/#review11134
-----------------------------------------------------------
Ship it!
Ship It!
- Steve Huston
On Sept. 6, 2012, 8:48 p.m., Chug Rolke wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6948/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2012, 8:48 p.m.)
>
>
> Review request for qpid, Andrew Stitcher and Steve Huston.
>
>
> Description
> -------
>
> Based on original work by Kerry Bonin in QPID-4257. The Windows SslConnector fails to properly relay connection events causing memory leaks and client hangs.
> With this patch the memory leaks are improved and clients doing fetch(FOREVER) are woken properly.
>
>
> This addresses bug QPID-4257.
> https://issues.apache.org/jira/browse/QPID-4257
>
>
> Diffs
> -----
>
> trunk/qpid/cpp/src/qpid/client/windows/SslConnector.cpp 1381603
>
> Diff: https://reviews.apache.org/r/6948/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chug Rolke
>
>