[GitHub] [airflow] ashb commented on a change in pull request #13421: BashOperator to raise AirflowSkipException on exit code 255

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #13421:
URL: https://github.com/apache/airflow/pull/13421#discussion_r551393852



##########
File path: airflow/example_dags/example_bash_operator.py
##########
@@ -71,5 +71,14 @@
 # [END howto_operator_bash_template]
 also_run_this >> run_this_last
 
+# [START howto_operator_bash_skip]
+this_will_skip = BashOperator(
+    task_id='this_will_skip',
+    bash_command='echo "hello world"; exit 255;',

Review comment:
       I'm not sure we should use 255 for this -- exit codes are not-fully defined, but >128 is usually "I died from a signal".
   
   > POSIX-compatible systems typically use a convention of zero for success and nonzero for error.[10] Some conventions have developed as to the relative meanings of various error codes; for example GNU recommend that codes with the high bit set be reserved for serious errors,[3]. 
   
   So perhaps using 127 would be better. (Exist code is an 8 bit integer)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org