You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/03/10 07:48:47 UTC
[GitHub] [camel-kamelets] oscerd opened a new pull request #51: Gmail Stream source kamelet
oscerd opened a new pull request #51:
URL: https://github.com/apache/camel-kamelets/pull/51
Fixes #19
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on a change in pull request #51: Gmail Stream source kamelet
Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #51:
URL: https://github.com/apache/camel-kamelets/pull/51#discussion_r591252458
##########
File path: google-mail-stream-source.kamelet.yaml
##########
@@ -0,0 +1,93 @@
+apiVersion: camel.apache.org/v1alpha1
+kind: Kamelet
+metadata:
+ name: google-mail-stream-source
+ annotations:
+ camel.apache.org/kamelet.icon: "data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjUyIDQyIDg4IDY2Ij4KPHBhdGggZmlsbD0iIzQyODVmNCIgZD0iTTU4IDEwOGgxNFY3NEw1MiA1OXY0M2MwIDMuMzIgMi42OSA2IDYgNiIvPgo8cGF0aCBmaWxsPSIjMzRhODUzIiBkPSJNMTIwIDEwOGgxNGMzLjMyIDAgNi0yLjY5IDYtNlY1OWwtMjAgMTUiLz4KPHBhdGggZmlsbD0iI2ZiYmMwNCIgZD0iTTEyMCA0OHYyNmwyMC0xNXYtOGMwLTcuNDItOC40Ny0xMS42NS0xNC40LTcuMiIvPgo8cGF0aCBmaWxsPSIjZWE0MzM1IiBkPSJNNzIgNzRWNDhsMjQgMTggMjQtMTh2MjZMOTYgOTIiLz4KPHBhdGggZmlsbD0iI2M1MjIxZiIgZD0iTTUyIDUxdjhsMjAgMTVWNDhsLTUuNi00LjJjLTUuOTQtNC40NS0xNC40LS4yMi0xNC40IDcuMiIvPgo8L3N2Zz4="
+ camel.apache.org/provider: "Apache Software Foundation"
+ labels:
+ camel.apache.org/kamelet.type: "source"
+spec:
+ definition:
+ title: "Google Mail Stream Source"
+ description: |-
+ Receive data from Google Mail.
+ required:
+ - index
+ - clientId
+ - accessToken
+ - refreshToken
+ - clientSecret
+ - applicationName
+ properties:
+ index:
+ title: Index
+ description: An index for the google mail endpoint
+ type: string
+ clientId:
+ title: Client Id
+ description: Client ID of the gmail application
+ type: string
+ x-descriptors:
+ - urn:alm:descriptor:com.tectonic.ui:password
+ clientSecret:
+ title: Client Secret
+ description: Client Secret of the gmail application
+ type: string
+ x-descriptors:
+ - urn:alm:descriptor:com.tectonic.ui:password
+ accessToken:
+ title: Access Token
+ description: OAuth 2 access token for google mail application. This typically expires after an hour so refreshToken is recommended for long term usage.
+ type: string
+ x-descriptors:
+ - urn:alm:descriptor:com.tectonic.ui:password
+ refreshToken:
+ title: Refresh Token
+ description: OAuth 2 refresh token for google mail application. Using this, the Google Calendar component can obtain a new accessToken whenever the current one expires - a necessity if the application is long-lived.
+ type: string
+ x-descriptors:
+ - urn:alm:descriptor:com.tectonic.ui:password
+ applicationName:
+ title: Application name
+ description: Google Mail application name
+ type: string
+ markAsRead:
+ title: Mark as read
+ description: Mark the message as read once it has been consumed
+ type: boolean
+ x-descriptors:
+ - 'urn:alm:descriptor:com.tectonic.ui:checkbox'
+ default: false
Review comment:
I'm ok, that is the camel catalog default, that's the reason
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] nicolaferraro merged pull request #51: Gmail Stream source kamelet
Posted by GitBox <gi...@apache.org>.
nicolaferraro merged pull request #51:
URL: https://github.com/apache/camel-kamelets/pull/51
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] nicolaferraro commented on a change in pull request #51: Gmail Stream source kamelet
Posted by GitBox <gi...@apache.org>.
nicolaferraro commented on a change in pull request #51:
URL: https://github.com/apache/camel-kamelets/pull/51#discussion_r591251015
##########
File path: google-mail-stream-source.kamelet.yaml
##########
@@ -0,0 +1,93 @@
+apiVersion: camel.apache.org/v1alpha1
+kind: Kamelet
+metadata:
+ name: google-mail-stream-source
+ annotations:
+ camel.apache.org/kamelet.icon: "data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjUyIDQyIDg4IDY2Ij4KPHBhdGggZmlsbD0iIzQyODVmNCIgZD0iTTU4IDEwOGgxNFY3NEw1MiA1OXY0M2MwIDMuMzIgMi42OSA2IDYgNiIvPgo8cGF0aCBmaWxsPSIjMzRhODUzIiBkPSJNMTIwIDEwOGgxNGMzLjMyIDAgNi0yLjY5IDYtNlY1OWwtMjAgMTUiLz4KPHBhdGggZmlsbD0iI2ZiYmMwNCIgZD0iTTEyMCA0OHYyNmwyMC0xNXYtOGMwLTcuNDItOC40Ny0xMS42NS0xNC40LTcuMiIvPgo8cGF0aCBmaWxsPSIjZWE0MzM1IiBkPSJNNzIgNzRWNDhsMjQgMTggMjQtMTh2MjZMOTYgOTIiLz4KPHBhdGggZmlsbD0iI2M1MjIxZiIgZD0iTTUyIDUxdjhsMjAgMTVWNDhsLTUuNi00LjJjLTUuOTQtNC40NS0xNC40LS4yMi0xNC40IDcuMiIvPgo8L3N2Zz4="
+ camel.apache.org/provider: "Apache Software Foundation"
+ labels:
+ camel.apache.org/kamelet.type: "source"
+spec:
+ definition:
+ title: "Google Mail Stream Source"
+ description: |-
+ Receive data from Google Mail.
+ required:
+ - index
+ - clientId
+ - accessToken
+ - refreshToken
+ - clientSecret
+ - applicationName
+ properties:
+ index:
+ title: Index
+ description: An index for the google mail endpoint
+ type: string
+ clientId:
+ title: Client Id
+ description: Client ID of the gmail application
+ type: string
+ x-descriptors:
+ - urn:alm:descriptor:com.tectonic.ui:password
+ clientSecret:
+ title: Client Secret
+ description: Client Secret of the gmail application
+ type: string
+ x-descriptors:
+ - urn:alm:descriptor:com.tectonic.ui:password
+ accessToken:
+ title: Access Token
+ description: OAuth 2 access token for google mail application. This typically expires after an hour so refreshToken is recommended for long term usage.
+ type: string
+ x-descriptors:
+ - urn:alm:descriptor:com.tectonic.ui:password
+ refreshToken:
+ title: Refresh Token
+ description: OAuth 2 refresh token for google mail application. Using this, the Google Calendar component can obtain a new accessToken whenever the current one expires - a necessity if the application is long-lived.
+ type: string
+ x-descriptors:
+ - urn:alm:descriptor:com.tectonic.ui:password
+ applicationName:
+ title: Application name
+ description: Google Mail application name
+ type: string
+ markAsRead:
+ title: Mark as read
+ description: Mark the message as read once it has been consumed
+ type: boolean
+ x-descriptors:
+ - 'urn:alm:descriptor:com.tectonic.ui:checkbox'
+ default: false
Review comment:
Better setting the default to `true`, so we have a streaming behavior without duplicates by default. Wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on a change in pull request #51: Gmail Stream source kamelet
Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #51:
URL: https://github.com/apache/camel-kamelets/pull/51#discussion_r591270725
##########
File path: google-mail-stream-source.kamelet.yaml
##########
@@ -0,0 +1,93 @@
+apiVersion: camel.apache.org/v1alpha1
+kind: Kamelet
+metadata:
+ name: google-mail-stream-source
+ annotations:
+ camel.apache.org/kamelet.icon: "data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjUyIDQyIDg4IDY2Ij4KPHBhdGggZmlsbD0iIzQyODVmNCIgZD0iTTU4IDEwOGgxNFY3NEw1MiA1OXY0M2MwIDMuMzIgMi42OSA2IDYgNiIvPgo8cGF0aCBmaWxsPSIjMzRhODUzIiBkPSJNMTIwIDEwOGgxNGMzLjMyIDAgNi0yLjY5IDYtNlY1OWwtMjAgMTUiLz4KPHBhdGggZmlsbD0iI2ZiYmMwNCIgZD0iTTEyMCA0OHYyNmwyMC0xNXYtOGMwLTcuNDItOC40Ny0xMS42NS0xNC40LTcuMiIvPgo8cGF0aCBmaWxsPSIjZWE0MzM1IiBkPSJNNzIgNzRWNDhsMjQgMTggMjQtMTh2MjZMOTYgOTIiLz4KPHBhdGggZmlsbD0iI2M1MjIxZiIgZD0iTTUyIDUxdjhsMjAgMTVWNDhsLTUuNi00LjJjLTUuOTQtNC40NS0xNC40LS4yMi0xNC40IDcuMiIvPgo8L3N2Zz4="
+ camel.apache.org/provider: "Apache Software Foundation"
+ labels:
+ camel.apache.org/kamelet.type: "source"
+spec:
+ definition:
+ title: "Google Mail Stream Source"
+ description: |-
+ Receive data from Google Mail.
+ required:
+ - index
+ - clientId
+ - accessToken
+ - refreshToken
+ - clientSecret
+ - applicationName
+ properties:
+ index:
+ title: Index
+ description: An index for the google mail endpoint
+ type: string
+ clientId:
+ title: Client Id
+ description: Client ID of the gmail application
+ type: string
+ x-descriptors:
+ - urn:alm:descriptor:com.tectonic.ui:password
+ clientSecret:
+ title: Client Secret
+ description: Client Secret of the gmail application
+ type: string
+ x-descriptors:
+ - urn:alm:descriptor:com.tectonic.ui:password
+ accessToken:
+ title: Access Token
+ description: OAuth 2 access token for google mail application. This typically expires after an hour so refreshToken is recommended for long term usage.
+ type: string
+ x-descriptors:
+ - urn:alm:descriptor:com.tectonic.ui:password
+ refreshToken:
+ title: Refresh Token
+ description: OAuth 2 refresh token for google mail application. Using this, the Google Calendar component can obtain a new accessToken whenever the current one expires - a necessity if the application is long-lived.
+ type: string
+ x-descriptors:
+ - urn:alm:descriptor:com.tectonic.ui:password
+ applicationName:
+ title: Application name
+ description: Google Mail application name
+ type: string
+ markAsRead:
+ title: Mark as read
+ description: Mark the message as read once it has been consumed
+ type: boolean
+ x-descriptors:
+ - 'urn:alm:descriptor:com.tectonic.ui:checkbox'
+ default: false
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org