You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by gi...@git.apache.org on 2017/07/20 18:55:25 UTC

[GitHub] vrahane commented on a change in pull request #442: Enabeling PWM1 and PWM2 on nrf52dk bsp

vrahane commented on a change in pull request #442: Enabeling PWM1 and PWM2 on nrf52dk bsp
URL: https://github.com/apache/mynewt-core/pull/442#discussion_r128602338
 
 

 ##########
 File path: hw/bsp/nrf52dk/pkg.yml
 ##########
 @@ -39,8 +39,8 @@ pkg.cflags:
     - '-DPDM_ENABLED=0'
     - '-DPERIPHERAL_RESOURCE_SHARING_ENABLED=1'
     - '-DPWM0_ENABLED=1'
-    - '-DPWM1_ENABLED=0'
-    - '-DPWM2_ENABLED=0'
+    - '-DPWM1_ENABLED=1'
+    - '-DPWM2_ENABLED=1'
 
 Review comment:
   @mlaz The default bsp in mynewt does not need to enable all PWMs. One is enabled and we can keep it at that to be used as an example. Any specific reason why you want to enable all by default ?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services