You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by BryanCutler <gi...@git.apache.org> on 2015/11/12 19:49:46 UTC
[GitHub] spark pull request: [SPARK-10086] [PySpark] [MLlib] Fix flaky Stre...
GitHub user BryanCutler opened a pull request:
https://github.com/apache/spark/pull/9670
[SPARK-10086] [PySpark] [MLlib] Fix flaky StreamingKMeans PySpark test
The test sometimes fails because `predictOn` would occur before `trainOn` with the input stream. This test is testing that the model gets updated and is able to predict correctly with the updated model. This fix allows more flexibility about when the update happens by repeating the final batch as the default RDD in the queueStream and checking that the last result matches the expected prediction of the updated model, within a timeout.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BryanCutler/spark flaky-StreamingKMeans-test-SPARK-10086
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9670.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9670
----
commit 44c9679d64c06954c9b2c2c61c85d5f3924f7444
Author: Bryan Cutler <bj...@us.ibm.com>
Date: 2015-11-12T18:37:07Z
[SPARK-10086] Fix flaky StreamingKMeans PySpark test by being flexible when model update occurs on the input stream
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10086] [PySpark] [MLlib] [Streaming] [T...
Posted by jkbradley <gi...@git.apache.org>.
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9670#issuecomment-169159539
@BryanCutler Any updates on this? I haven't heard new ideas of the real cause from others myself. I'd suggest closing the PR for now, until we can figure out the underlying issue, since it seems like the streaming tests are fairly stable. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10086] [PySpark] [MLlib] Fix flaky Stre...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9670#issuecomment-156206577
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/45757/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10086] [PySpark] [MLlib] Fix flaky Stre...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9670#issuecomment-156200014
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10086] [PySpark] [MLlib] [Streaming] [T...
Posted by BryanCutler <gi...@git.apache.org>.
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/9670#issuecomment-169163501
@jkbradley, I haven't had much time to look into the root cause, but I'm still planning to get to it. I'll close this and open another once I have something.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10086] [PySpark] [MLlib] Fix flaky Stre...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9670#issuecomment-156201393
**[Test build #45757 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45757/consoleFull)** for PR 9670 at commit [`44c9679`](https://github.com/apache/spark/commit/44c9679d64c06954c9b2c2c61c85d5f3924f7444).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10086] [PySpark] [MLlib] Fix flaky Stre...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9670#issuecomment-156206576
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10086] [PySpark] [MLlib] [Streaming] [T...
Posted by BryanCutler <gi...@git.apache.org>.
Github user BryanCutler closed the pull request at:
https://github.com/apache/spark/pull/9670
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10086] [PySpark] [MLlib] Fix flaky Stre...
Posted by BryanCutler <gi...@git.apache.org>.
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/9670#issuecomment-156200172
When `predictOn` happens first, the predicted results and model look like this
```
Predict: [[0, 1, 1], [0, 0, 0], [0, 0, 0], [0, 0, 0], [1, 0, 1]]
Centers: [[-0.1 ] [ 0.25]]
Weights: [1.0, 2.0], Decay: 0.0
```
Which would have failed before, but is able to pass with this fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10086] [PySpark] [MLlib] Fix flaky Stre...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9670#issuecomment-156199992
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10086] [PySpark] [MLlib] Fix flaky Stre...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9670#issuecomment-156206421
**[Test build #45757 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45757/consoleFull)** for PR 9670 at commit [`44c9679`](https://github.com/apache/spark/commit/44c9679d64c06954c9b2c2c61c85d5f3924f7444).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org