Re: [PR] [core] index mapping push down to format reader and skip partition value reading from file [incubator-paimon]

["JingsongLi (via GitHub)" <gi...@apache.org>]

JingsongLi commented on code in PR #2257:
URL: https://github.com/apache/incubator-paimon/pull/2257#discussion_r1391104672


##########
paimon-format/src/main/java/org/apache/paimon/format/orc/OrcReaderFactory.java:
##########
@@ -93,9 +95,28 @@ public OrcVectorizedReader createReader(FileIO fileIO, Path file) throws IOExcep
     }
 
     @Override
-    public OrcVectorizedReader createReader(FileIO fileIO, Path file, int poolSize)
+    public OrcVectorizedReader createReader(FileIO fileIO, Path file, int pooSize)

Review Comment:
   revert?



##########
paimon-common/src/main/java/org/apache/paimon/format/FormatReaderFactory.java:
##########
@@ -33,4 +36,19 @@ public interface FormatReaderFactory extends Serializable {
 
     RecordReader<InternalRow> createReader(FileIO fileIO, Path file, int poolSize)
             throws IOException;
+
+    RecordReader<InternalRow> createReader(

Review Comment:
   Do we need to introduce these methods?
   
   I think we can just handle return value from `RecordReader`.
   ```
   if (it is a partitioned table) {
     if (it is a `ColumnarRowIterator`) {
       then use `VectorMappingUtils.wrap`;
     } else {
       use a PartitionedRow to wrap it;
     }
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org