You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/05/13 07:20:31 UTC

[GitHub] [skywalking-java] wu-sheng commented on pull request #174: Add `plugin.jdbc.trace_sql_parameters` into Configuration Discovery S…

wu-sheng commented on PR #174:
URL: https://github.com/apache/skywalking-java/pull/174#issuecomment-1125734652

   I think we still need some discussions, why do you need adding a new method to `ConfigurationDiscoveryService`? This breaks many things and brings the plugin logic into the agent core.
   
   You should change the `ConfigurationDiscoveryService` to support multiple watchers to watch one key, and implement the collecting checker inside the plugin only.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org