You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2015/04/14 16:23:38 UTC
Review Request 33167: Create widget -> Metrics and Expression page:
Misc UI tweaks
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33167/
-----------------------------------------------------------
Review request for Ambari and Aleksandr Kovalenko.
Bugs: AMBARI-10465
https://issues.apache.org/jira/browse/AMBARI-10465
Repository: ambari
Description
-------
Tweaks to be done:
Rename Discard button of Expression builder to Reset and Save button to Done
Next button on this step should not be enable until all expressions are entered and "Done button" on all expression box is clicked.
For Graph widget type, We need to have "label" for each expression builder and "Add data set" button as mocked in the design mocks for graph widget type (link). Clicking on "Add data set" link should present another expression box on the page as shown in design mockup.
On "Add Metric" popup window snapshot-4.png, Do not allow multiple selection.
On "Add Metric" popup window snapshot-4.png, Show displayName in the list of components instead of actual service name.
On "Add Metric" popup window snapshot-4.png, Show 2 options for each master component: "All ${MasterComponent DisplayName}s" and "Active ${MasterComponent DisplayName}". Same as designed in the mockup
On "Add Metric" popup window: While rendering metric names, Render sorted (sort by name) list of filtered metric names.
On "Add Metric" popup window snapshot-5.png, Lets not disable "select a component" combobox and remove cancel button. Allow the user to always change component name . This should dynamically render new list of metric names
Combobox for metric selection should also support filtering metrics as user types the name.
Lets make the cancel image on chosen metrics (snapshot-6.png) appear only on hover. Also not keep it red signifying something is critical or incorrect. We can use any other lighter color (#A69B9B)
Diffs
-----
ambari-web/app/controllers/main/service/widgets/create/step2_controller.js cfa555fc16e64b312f536fff15fcf83fa124b160
ambari-web/app/messages.js 39117b7d9ab062b7e505120771759083d8e12a1b
ambari-web/app/styles/enhanced_service_dashboard.less 520d844c7c9029342b9dfca0e56c9f35f471157d
ambari-web/app/templates/main/service/widgets/create/expression.hbs e57942c9d520e241ccb6dc5fb3d1d20c1ae675ac
ambari-web/app/templates/main/service/widgets/create/step2.hbs f8f38482f66e269ed92b05f7f73fa541f2ea727d
ambari-web/app/templates/main/service/widgets/create/step2_add_metric.hbs d2d90a8effd075e1e67b3c85df0ee083cb68ea4a
ambari-web/app/views/main/service/widgets/create/expression_view.js ba4c47e3af2b2b509078d7be393314bb93fe030b
ambari-web/app/views/main/service/widgets/create/step2_view.js d6711c24a279e75224f36c693df2a9e8d58a9373
ambari-web/vendor/scripts/chosen.jquery.min.js PRE-CREATION
ambari-web/vendor/styles/chosen.min.css PRE-CREATION
Diff: https://reviews.apache.org/r/33167/diff/
Testing
-------
5803 tests complete (11 seconds)
78 tests pending
Thanks,
Andrii Tkach