[jira] [Work logged] (GOBBLIN-825) Cache record schema in Plain Object reporters rather than create a new schema each time

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-825?focusedWorklogId=276897&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-276897 ]

ASF GitHub Bot logged work on GOBBLIN-825:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Jul/19 18:01
            Start Date: 15/Jul/19 18:01
    Worklog Time Spent: 10m 
      Work Description: vikrambohra commented on pull request #2686: [GOBBLIN-825] Make schema a member variable and override name and nam…
URL: https://github.com/apache/incubator-gobblin/pull/2686
 
 
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-825
   
   
   ### Description
   - [ ] Here are some details about my PR, including screenshots (if applicable):
   An issue with a schema registry client caused this issue. This issue fixes the creation of new instances of the same schema for every message sent. Instead we now create an instance of the schema during object construction and use the same schema instance for all the messages.
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   - overrideSchemaNameAndNamespaceTest in AvroUtilsTest.java
   - KeyValueEventObjectReporterTest.java
   - KeyValueMetricObjectReporterTest.java
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 276897)
            Time Spent: 10m
    Remaining Estimate: 0h

> Cache record schema in Plain Object reporters rather than create a new schema each time
> ---------------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-825
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-825
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: Vikram Bohra
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Rather than create a new instance of the same schema each time, it is better to create once and re-use. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)