[GitHub] [kafka] mjsax commented on a diff in pull request #12867: KAFKA-13785: docs for emit final

[GitBox <gi...@apache.org>]

mjsax commented on code in PR #12867:
URL: https://github.com/apache/kafka/pull/12867#discussion_r1024420977


##########
streams/src/main/java/org/apache/kafka/streams/kstream/SessionWindowedKStream.java:
##########
@@ -644,6 +644,16 @@ KTable<Windowed<K>, V> reduce(final Reducer<V> reducer,
                                   final Named named,
                                   final Materialized<K, V, SessionStore<Bytes, byte[]>> materialized);
 
-    // TODO: add javadoc
+    /**
+     * Configure when the aggregated result will be emitted for {@code SessionWindowedKStream}.
+     * <p>
+     * For example, for {@link EmitStrategy#onWindowClose} strategy, the aggregated result for a
+     * window will only be emitted when the window closes. For {@link EmitStrategy#onWindowUpdate()}
+     * strategy, the aggregated result for a window will be emitted whenever there is an update to

Review Comment:
   > emitted whenever there is an update
   
   Should we mention caching in addition?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org