[jira] [Comment Edited] (HBASE-20724) Sometimes some compacted storefiles are still opened after region failover

["Guanghao Zhang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-20724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771898#comment-16771898 ] 

Guanghao Zhang edited comment on HBASE-20724 at 2/19/19 12:55 PM:
------------------------------------------------------------------

Add a ut in 001 patch. The ut will flush 3 storefile and major compact to 1 storefile. Then roll WAL and flush again to make the old WAL was archived. Then kill the regionserver to failover. The region will be opened in a new regionserver but will have 3+1 storefiles. So The last assertEquals(1, store.getStorefilesCount()); will fail now.


was (Author: zghaobac):
Add a ut in 001 patch. The ut will flush 3 storefile and major compact to 1 storefile. Then roll WAL and flush again to make the old WAL was archived. Then kill the regionserver to failover. The region will be opened in a new regionserver but will have 3+1 storefiles. So The last assertEquals(1, store.getStorefilesCount()); will failed now.

> Sometimes some compacted storefiles are still opened after region failover
> --------------------------------------------------------------------------
>
>                 Key: HBASE-20724
>                 URL: https://issues.apache.org/jira/browse/HBASE-20724
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0
>            Reporter: Francis Liu
>            Assignee: Guanghao Zhang
>            Priority: Critical
>         Attachments: HBASE-20724.master.001.patch
>
>
> It is important that compacted storefiles of a given compaction execution are wholly opened or archived to insure data consistency. ie a storefile containing delete tombstones can be archived while older storefiles containing cells that were supposed to be deleted are left unarchived thereby undeleting those cells.
> When a server fails compaction markers (in the wal edit) are used to determine which storefiles are compacted and should be excluded during region open (during failover). But the WALs containing compaction markers can be prematurely archived even though there are still compacted storefiles for that particular compaction event that hasn't been archived yet. Thus losing compaction information that needs to be replayed in the event of an RS crash. This is because hlog archiving logic only keeps track of flushed storefiles and not compacted ones.
> https://issues.apache.org/jira/browse/HBASE-20704?focusedCommentId=16507680&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16507680



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)