You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/01/30 07:24:45 UTC

[GitHub] mridulm commented on issue #23686: [SPARK-26772][YARN] YARNHadoopDelegationTokenManager loads ServiceCredentialProviders independently

mridulm commented on issue #23686: [SPARK-26772][YARN] YARNHadoopDelegationTokenManager loads ServiceCredentialProviders independently
URL: https://github.com/apache/spark/pull/23686#issuecomment-458839459
 
 
   @vanzin We do not have an alternative for custom credential providers without this, do we ?
   
   We could expose `HadoopDelegationTokenManager` as `DeveloperApi`, add support for loading custom providers via `ServiceLoader` there (roll this fix into that class) and remove `YARNHadoopDelegationTokenManager` for 3.0 (all existing providers extend from `HadoopDelegationTokenManager` instead of `YARNHadoopDelegationTokenManager`).
   
   If that is the proposal, I am fine with that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org