You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/10/02 14:22:55 UTC
Re: Review Request 71560: Made the MaintenanceInverseOffers test use
only one framework.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71560/#review218021
-----------------------------------------------------------
Ship it!
Thanks for fixing this!
- Meng Zhu
On Sept. 30, 2019, 6:33 a.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71560/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2019, 6:33 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Meng Zhu.
>
>
> Bugs: MESOS-9980
> https://issues.apache.org/jira/browse/MESOS-9980
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch simplifies the test and attepmts to fix MESOS-9980 by
> removing the (potential) flakiness caused by agent2's resources
> being re-offered to framework2.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp a13eb017f7a93ee67c8426e4150858a547175ed6
>
>
> Diff: https://reviews.apache.org/r/71560/diff/1/
>
>
> Testing
> -------
>
> `./bin/mesos-tests.sh --gtest_filter="*MaintenanceInverseOffers*" --gtest_break_on_failure --gtest_repeat=10000`
>
> `./bin/mesos-tests.sh --gtest_filter="*MaintenanceInverseOffers*" --gtest_break_on_failure` fails if I break framework untracking in `Slave::increaseAvailable()` in the allocator.
>
>
> Thanks,
>
> Andrei Sekretenko
>
>