You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@incubator.apache.org by Jaroslav Tulach <ja...@gmail.com> on 2018/11/18 04:47:53 UTC
[VOTE] Release 1.6 of NetBeans HTML/Java API
Hi.
The NetBeans incubating community has just approved the release of
HTML/Java API version 1.6. See the discussion at
https://lists.apache.org/thread.html/4872c46f400fda4b564080928933494e346b99a92c66cab213459949@%3Cdev.netbeans.apache.org%3E
which contains the technical information as well as three +1 votes from the
community members Junichi, John and Jan.
As a result of such unison approval, I'd like to ask you to hold the
Incubator PMC vote to release:
https://dist.apache.org/repos/dist/dev/incubator/netbeans/incubating-netbeans-html4j/incubating-netbeans-html4j-1.6/
as well as associated staged Maven artifacts at
https://repository.apache.org/content/repositories/orgapachenetbeans-1002/
as NetBeans HTML/Java Incubating API version 1.6. Can you cast your votes
in next 72h, please?
Thanks.
-jt
> (an) ... attempt of HTML/Java 1.6 bits ... (was) uploaded ...
> to [Apache Nexus](https://repository.apache.org/) staging repository.
> The upload is the final piece in the whole HTML/Java API donation process
-
> it was only possible now, when the netbeans.org domain (and thus
> org.netbeans.html groupId) has been donated to Apache Foundation.
>
> To finish the whole process, I am calling for a vote on Apache NetBeans
> HTML/Java 1.6 release. The release is staged at
>
>
https://dist.apache.org/repos/dist/dev/incubator/netbeans/incubating-netbeans-html4j/incubating-netbeans-html4j-1.6/
>
> In addition to that the Maven artifacts built from the same changeset
> [release-1.6](
https://github.com/apache/incubator-netbeans-html4j/tree/release-1.6)
> are available at the following staging repository:
>
> https://repository.apache.org/content/repositories/orgapachenetbeans-1002/
>
Re: [VOTE] Release 1.6 of NetBeans HTML/Java API
Posted by Bertrand Delacretaz <bd...@codeconsult.ch>.
On Sun, Nov 18, 2018 at 5:48 AM Jaroslav Tulach
<ja...@gmail.com> wrote:
> ...As a result of such unison approval, I'd like to ask you to hold the
> Incubator PMC vote to release:
> https://dist.apache.org/repos/dist/dev/incubator/netbeans/incubating-netbeans-html4j/incubating-netbeans-html4j-1.6/ ...
+1 for the release of incubating-netbeans-html4j-1.6.zip
with SHA256=3d8c554df95f13b1789130c2dcacf560562bcc61f159af39bed5d82e1f2ab01b
I haven't checked binaries or Maven artifacts.
SHA256 digest matches (I think the other ones should be removed),
DISCLAIMER, LICENSE, NOTICE and DEPENDENCIES look good to me.
The build with "mvn clean install" didn't work, I got
> Running TestSuite
> Configuring TestNG with: TestNG652Configurator
> java.lang.Exception: Error
> at org.netbeans.html.json.impl.OnReceiveTest.performErrorJSONCallNoHandling(OnReceiveTest.java:64)
Not necessarily a blocker for the release from my point of view.
Tested with java version "1.8.0_171 and Apache Maven 3.6.0.
One thing that I noticed but do not consider a blocker, the file
./ko4j/src/main/resources/org/netbeans/html/ko4j/knockout-3.4.0.js
is distributed minified which IMO doesn't match the spirit of
releasing source code - reviewing that code is next to impossible, I'd
prefer the actual source code to be distributed and minified during
the build if needed.
-Bertrand
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release 1.6 of NetBeans HTML/Java API
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
+1 binding but there’s a LICENSE issue than needs to be fixed in the next release.
I checkered:
- incubating in name
- signatures and hashes correct
- DISCLAIMER exists (although name of the project inside is a little odd)
- LICENSE and NOTICE have a few minor issues (see below)
- No unexpected binary files
- All ASF file have ASF headers
- Can compile from source
The tests also passed.
The NOTICE copyright year is “2017-2017” that should be 2017-2018 right?
The LICENSE is missing mention of (and license text) of MIT licensed Knockout [1]
Thanks,
Justin
1. incubator-netbeans-html4j/ko4j/src/main/resources/org/netbeans/html/ko4j/knockout-3.4.0.js
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release 1.6 of NetBeans HTML/Java API
Posted by Ate Douma <at...@douma.nu>.
Now provided sha256 checksum checked to be correct.
Hereby changing my vote back to +1 (binding)
Regards,
Ate
On 19/11/2018 15.40, Ate Douma wrote:
> Sorry about overlooking this before, but as Henk P. Penning indicated
> release artifacts now MUST be accompanied by a SHA-256 and/or SHA-512
> checksum file (after 18 Aug 2018).
>
> I therefore change my vote to -1 (binding) for this release candidate.
> I will change it back to +1 when at least a SHA-256 checksum file is
> added.
>
> (see also the vote thread for Netbeans 10.0 and Bertrand's likewise
> comment and temporary change of vote).
>
> Ate
>
>
> On 18/11/2018 22.29, Ate Douma wrote:
>> +1 binding
>>
>> - signature and sha1 files correct (note: .md5 no longer needed/desired)
>> - LICENSE and NOTICE files correct
>> - source dist contents matches with contents of git release-1.6 tag
>>
>> Regards,
>> Ate
>>
>> On 18/11/2018 05.47, Jaroslav Tulach wrote:
>>> Hi.
>>> The NetBeans incubating community has just approved the release of
>>> HTML/Java API version 1.6. See the discussion at
>>> https://lists.apache.org/thread.html/4872c46f400fda4b564080928933494e346b99a92c66cab213459949@%3Cdev.netbeans.apache.org%3E
>>>
>>> which contains the technical information as well as three +1 votes
>>> from the
>>> community members Junichi, John and Jan.
>>> As a result of such unison approval, I'd like to ask you to hold the
>>> Incubator PMC vote to release:
>>>
>>> https://dist.apache.org/repos/dist/dev/incubator/netbeans/incubating-netbeans-html4j/incubating-netbeans-html4j-1.6/
>>>
>>> as well as associated staged Maven artifacts at
>>> https://repository.apache.org/content/repositories/orgapachenetbeans-1002/
>>>
>>>
>>> as NetBeans HTML/Java Incubating API version 1.6. Can you cast your
>>> votes
>>> in next 72h, please?
>>>
>>> Thanks.
>>> -jt
>>>
>>>> (an) ... attempt of HTML/Java 1.6 bits ... (was) uploaded ...
>>>> to [Apache Nexus](https://repository.apache.org/) staging repository.
>>>> The upload is the final piece in the whole HTML/Java API donation
>>>> process
>>> -
>>>> it was only possible now, when the netbeans.org domain (and thus
>>>> org.netbeans.html groupId) has been donated to Apache Foundation.
>>>>
>>>> To finish the whole process, I am calling for a vote on Apache NetBeans
>>>> HTML/Java 1.6 release. The release is staged at
>>>>
>>>>
>>> https://dist.apache.org/repos/dist/dev/incubator/netbeans/incubating-netbeans-html4j/incubating-netbeans-html4j-1.6/
>>>
>>>>
>>>> In addition to that the Maven artifacts built from the same changeset
>>>> [release-1.6](
>>> https://github.com/apache/incubator-netbeans-html4j/tree/release-1.6)
>>>> are available at the following staging repository:
>>>>
>>>> https://repository.apache.org/content/repositories/orgapachenetbeans-1002/
>>>>
>>>>
>>>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release 1.6 of NetBeans HTML/Java API
Posted by Ate Douma <at...@douma.nu>.
Sorry about overlooking this before, but as Henk P. Penning indicated
release artifacts now MUST be accompanied by a SHA-256 and/or SHA-512
checksum file (after 18 Aug 2018).
I therefore change my vote to -1 (binding) for this release candidate.
I will change it back to +1 when at least a SHA-256 checksum file is
added.
(see also the vote thread for Netbeans 10.0 and Bertrand's likewise
comment and temporary change of vote).
Ate
On 18/11/2018 22.29, Ate Douma wrote:
> +1 binding
>
> - signature and sha1 files correct (note: .md5 no longer needed/desired)
> - LICENSE and NOTICE files correct
> - source dist contents matches with contents of git release-1.6 tag
>
> Regards,
> Ate
>
> On 18/11/2018 05.47, Jaroslav Tulach wrote:
>> Hi.
>> The NetBeans incubating community has just approved the release of
>> HTML/Java API version 1.6. See the discussion at
>> https://lists.apache.org/thread.html/4872c46f400fda4b564080928933494e346b99a92c66cab213459949@%3Cdev.netbeans.apache.org%3E
>>
>> which contains the technical information as well as three +1 votes
>> from the
>> community members Junichi, John and Jan.
>> As a result of such unison approval, I'd like to ask you to hold the
>> Incubator PMC vote to release:
>>
>> https://dist.apache.org/repos/dist/dev/incubator/netbeans/incubating-netbeans-html4j/incubating-netbeans-html4j-1.6/
>>
>> as well as associated staged Maven artifacts at
>> https://repository.apache.org/content/repositories/orgapachenetbeans-1002/
>>
>>
>> as NetBeans HTML/Java Incubating API version 1.6. Can you cast your votes
>> in next 72h, please?
>>
>> Thanks.
>> -jt
>>
>>> (an) ... attempt of HTML/Java 1.6 bits ... (was) uploaded ...
>>> to [Apache Nexus](https://repository.apache.org/) staging repository.
>>> The upload is the final piece in the whole HTML/Java API donation
>>> process
>> -
>>> it was only possible now, when the netbeans.org domain (and thus
>>> org.netbeans.html groupId) has been donated to Apache Foundation.
>>>
>>> To finish the whole process, I am calling for a vote on Apache NetBeans
>>> HTML/Java 1.6 release. The release is staged at
>>>
>>>
>> https://dist.apache.org/repos/dist/dev/incubator/netbeans/incubating-netbeans-html4j/incubating-netbeans-html4j-1.6/
>>
>>>
>>> In addition to that the Maven artifacts built from the same changeset
>>> [release-1.6](
>> https://github.com/apache/incubator-netbeans-html4j/tree/release-1.6)
>>> are available at the following staging repository:
>>>
>>> https://repository.apache.org/content/repositories/orgapachenetbeans-1002/
>>>
>>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release 1.6 of NetBeans HTML/Java API
Posted by Ate Douma <at...@douma.nu>.
+1 binding
- signature and sha1 files correct (note: .md5 no longer needed/desired)
- LICENSE and NOTICE files correct
- source dist contents matches with contents of git release-1.6 tag
Regards,
Ate
On 18/11/2018 05.47, Jaroslav Tulach wrote:
> Hi.
> The NetBeans incubating community has just approved the release of
> HTML/Java API version 1.6. See the discussion at
> https://lists.apache.org/thread.html/4872c46f400fda4b564080928933494e346b99a92c66cab213459949@%3Cdev.netbeans.apache.org%3E
> which contains the technical information as well as three +1 votes from the
> community members Junichi, John and Jan.
> As a result of such unison approval, I'd like to ask you to hold the
> Incubator PMC vote to release:
>
> https://dist.apache.org/repos/dist/dev/incubator/netbeans/incubating-netbeans-html4j/incubating-netbeans-html4j-1.6/
> as well as associated staged Maven artifacts at
> https://repository.apache.org/content/repositories/orgapachenetbeans-1002/
>
> as NetBeans HTML/Java Incubating API version 1.6. Can you cast your votes
> in next 72h, please?
>
> Thanks.
> -jt
>
>> (an) ... attempt of HTML/Java 1.6 bits ... (was) uploaded ...
>> to [Apache Nexus](https://repository.apache.org/) staging repository.
>> The upload is the final piece in the whole HTML/Java API donation process
> -
>> it was only possible now, when the netbeans.org domain (and thus
>> org.netbeans.html groupId) has been donated to Apache Foundation.
>>
>> To finish the whole process, I am calling for a vote on Apache NetBeans
>> HTML/Java 1.6 release. The release is staged at
>>
>>
> https://dist.apache.org/repos/dist/dev/incubator/netbeans/incubating-netbeans-html4j/incubating-netbeans-html4j-1.6/
>>
>> In addition to that the Maven artifacts built from the same changeset
>> [release-1.6](
> https://github.com/apache/incubator-netbeans-html4j/tree/release-1.6)
>> are available at the following staging repository:
>>
>> https://repository.apache.org/content/repositories/orgapachenetbeans-1002/
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release 1.6 of NetBeans HTML/Java API
Posted by "Henk P. Penning" <pe...@uu.nl>.
On Sun, 18 Nov 2018, Jaroslav Tulach wrote:
> Date: Sun, 18 Nov 2018 05:47:53 +0100
> From: Jaroslav Tulach <ja...@gmail.com>
> To: Incubator General <ge...@incubator.apache.org>
> Subject: [VOTE] Release 1.6 of NetBeans HTML/Java API
> The NetBeans incubating community has just approved the release of
> HTML/Java API version 1.6. See the discussion at
> https://lists.apache.org/thread.html/4872c46f400fda4b564080928933494e346b99a92c66cab213459949@%3Cdev.netbeans.apache.org%3E
> which contains the technical information as well as three +1 votes from the
> community members Junichi, John and Jan.
> As a result of such unison approval, I'd like to ask you to hold the
> Incubator PMC vote to release:
>
> https://dist.apache.org/repos/dist/dev/incubator/netbeans/incubating-netbeans-html4j/incubating-netbeans-html4j-1.6/
policy :
https://www.apache.org/dev/release-distribution#sigs-and-sums
-- you MUST supply a SHA-256 and/or SHA-512 checksum file
-- you SHOULD NOT supply a MD5 or SHA-1 checksum file
Please fix this and the vote may continue.
HPP
------------------------------------------------------------ _
Henk P. Penning, ICT-beta R Uithof MG-403 _/ \_
Faculty of Science, Utrecht University T +31 30 253 4106 / \_/ \
Leuvenlaan 4, 3584CE Utrecht, NL F +31 30 253 4553 \_/ \_/
http://www.staff.science.uu.nl/~penni101/ M penning@uu.nl \_/
> as well as associated staged Maven artifacts at
> https://repository.apache.org/content/repositories/orgapachenetbeans-1002/
>
> as NetBeans HTML/Java Incubating API version 1.6. Can you cast your votes
> in next 72h, please?
>
> Thanks.
> -jt
>
>> (an) ... attempt of HTML/Java 1.6 bits ... (was) uploaded ...
>> to [Apache Nexus](https://repository.apache.org/) staging repository.
>> The upload is the final piece in the whole HTML/Java API donation process
> -
>> it was only possible now, when the netbeans.org domain (and thus
>> org.netbeans.html groupId) has been donated to Apache Foundation.
>>
>> To finish the whole process, I am calling for a vote on Apache NetBeans
>> HTML/Java 1.6 release. The release is staged at
>>
>>
> https://dist.apache.org/repos/dist/dev/incubator/netbeans/incubating-netbeans-html4j/incubating-netbeans-html4j-1.6/
>>
>> In addition to that the Maven artifacts built from the same changeset
>> [release-1.6](
> https://github.com/apache/incubator-netbeans-html4j/tree/release-1.6)
>> are available at the following staging repository:
>>
>> https://repository.apache.org/content/repositories/orgapachenetbeans-1002/
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org