You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Prasad Mujumdar (Created) (JIRA)" <ji...@apache.org> on 2012/04/17 23:39:13 UTC
[jira] [Created] (FLUME-1126) Support RFC 3164 and 5424 syslog
format timestamp parsing
Support RFC 3164 and 5424 syslog format timestamp parsing
---------------------------------------------------------
Key: FLUME-1126
URL: https://issues.apache.org/jira/browse/FLUME-1126
Project: Flume
Issue Type: Improvement
Components: Sinks+Sources
Affects Versions: v1.2.0
Reporter: Prasad Mujumdar
Assignee: Prasad Mujumdar
Fix For: v1.2.0
Support RFC 3164 and 5424 syslog format timestamp parsing for syslog source
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1126) Support RFC 3164 and 5424 syslog
format timestamp parsing
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257819#comment-13257819 ]
jiraposter@reviews.apache.org commented on FLUME-1126:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4809/
-----------------------------------------------------------
(Updated 2012-04-19 21:12:31.203532)
Review request for Flume, Arvind Prabhakar and Mike Percy.
Changes
-------
Added config to bypass version
Fixed the RFC5424 timezone format
Summary
-------
Support for timestamp and hostname parsing.
This addresses bug FLUME-1126.
https://issues.apache.org/jira/browse/FLUME-1126
Diffs (updated)
-----
pom.xml ed8092d
flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 8b1f7c5
flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java 3a7c486
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java 653f5eb
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 732cce5
flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java b0485b1
Diff: https://reviews.apache.org/r/4809/diff
Testing
-------
Updated syslog tests to cover timestamp and hostname handling.
Manually tested using syslog4j
Thanks,
Prasad
> Support RFC 3164 and 5424 syslog format timestamp parsing
> ---------------------------------------------------------
>
> Key: FLUME-1126
> URL: https://issues.apache.org/jira/browse/FLUME-1126
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.2.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: v1.2.0
>
>
> Support RFC 3164 and 5424 syslog format timestamp parsing for syslog source
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1126) Support RFC 3164 and 5424 syslog
format timestamp parsing
Posted by "Arvind Prabhakar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arvind Prabhakar updated FLUME-1126:
------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Patch committed. Thanks Prasad!
> Support RFC 3164 and 5424 syslog format timestamp parsing
> ---------------------------------------------------------
>
> Key: FLUME-1126
> URL: https://issues.apache.org/jira/browse/FLUME-1126
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.2.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: v1.2.0
>
> Attachments: FLUME-1126-9.patch
>
>
> Support RFC 3164 and 5424 syslog format timestamp parsing for syslog source
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1126) Support RFC 3164 and 5424 syslog
format timestamp parsing
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258002#comment-13258002 ]
jiraposter@reviews.apache.org commented on FLUME-1126:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4809/
-----------------------------------------------------------
(Updated 2012-04-20 03:19:50.057771)
Review request for Flume, Arvind Prabhakar and Mike Percy.
Changes
-------
hmm .. not sure why. just regenerated the diff and verified applying patch.
Let me know if you still see the problem.
Summary
-------
Support for timestamp and hostname parsing.
This addresses bug FLUME-1126.
https://issues.apache.org/jira/browse/FLUME-1126
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java b0485b1
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 732cce5
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java 653f5eb
flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java 3a7c486
flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 8b1f7c5
Diff: https://reviews.apache.org/r/4809/diff
Testing
-------
Updated syslog tests to cover timestamp and hostname handling.
Manually tested using syslog4j
Thanks,
Prasad
> Support RFC 3164 and 5424 syslog format timestamp parsing
> ---------------------------------------------------------
>
> Key: FLUME-1126
> URL: https://issues.apache.org/jira/browse/FLUME-1126
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.2.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: v1.2.0
>
>
> Support RFC 3164 and 5424 syslog format timestamp parsing for syslog source
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1126) Support RFC 3164 and 5424 syslog
format timestamp parsing
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263717#comment-13263717 ]
jiraposter@reviews.apache.org commented on FLUME-1126:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4809/
-----------------------------------------------------------
(Updated 2012-04-27 14:58:21.377103)
Review request for Flume, Arvind Prabhakar and Mike Percy.
Changes
-------
Refactored to use regex for syslog header format. Also additional config to specify add-hoc format
Summary
-------
Support for timestamp and hostname parsing.
This addresses bug FLUME-1126.
https://issues.apache.org/jira/browse/FLUME-1126
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java b0485b1
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 732cce5
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java 653f5eb
flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 8b1f7c5
Diff: https://reviews.apache.org/r/4809/diff
Testing
-------
Updated syslog tests to cover timestamp and hostname handling.
Manually tested using syslog4j
Thanks,
Prasad
> Support RFC 3164 and 5424 syslog format timestamp parsing
> ---------------------------------------------------------
>
> Key: FLUME-1126
> URL: https://issues.apache.org/jira/browse/FLUME-1126
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.2.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: v1.2.0
>
>
> Support RFC 3164 and 5424 syslog format timestamp parsing for syslog source
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1126) Support RFC 3164 and 5424 syslog
format timestamp parsing
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263800#comment-13263800 ]
Hudson commented on FLUME-1126:
-------------------------------
Integrated in flume-trunk #187 (See [https://builds.apache.org/job/flume-trunk/187/])
FLUME-1126. Support RFC 3164 and 5424 syslog formats
(Prasad Mujumdar via Arvind Prabhakar) (Revision 1331498)
Result = SUCCESS
arvind : http://svn.apache.org/viewvc/?view=rev&rev=1331498
Files :
* /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java
* /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java
* /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
* /incubator/flume/trunk/flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java
> Support RFC 3164 and 5424 syslog format timestamp parsing
> ---------------------------------------------------------
>
> Key: FLUME-1126
> URL: https://issues.apache.org/jira/browse/FLUME-1126
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.2.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: v1.2.0
>
> Attachments: FLUME-1126-9.patch
>
>
> Support RFC 3164 and 5424 syslog format timestamp parsing for syslog source
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1126) Support RFC 3164 and 5424 syslog
format timestamp parsing
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263983#comment-13263983 ]
jiraposter@reviews.apache.org commented on FLUME-1126:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4809/#review7321
-----------------------------------------------------------
Interesting approach, Prasad. Looks pretty nice. I just have a couple of comments.
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
<https://reviews.apache.org/r/4809/#comment16167>
The RFC5424 version field should be a digit followed by a space. So I think this pattern should be: "(?:\\d\\s)?"; i.e. no [] character class around in. Worth adding a unit test w/ the example messages from RFC5424 to be sure it's compliant.
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
<https://reviews.apache.org/r/4809/#comment16177>
Why would the Scanner be closed? Shouldn't this exception be logged or re-thrown?
- Mike
On 2012-04-27 14:58:21, Prasad Mujumdar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4809/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-27 14:58:21)
bq.
bq.
bq. Review request for Flume, Arvind Prabhakar and Mike Percy.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Support for timestamp and hostname parsing.
bq.
bq.
bq. This addresses bug FLUME-1126.
bq. https://issues.apache.org/jira/browse/FLUME-1126
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java b0485b1
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 732cce5
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java 653f5eb
bq. flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 8b1f7c5
bq.
bq. Diff: https://reviews.apache.org/r/4809/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated syslog tests to cover timestamp and hostname handling.
bq. Manually tested using syslog4j
bq.
bq.
bq. Thanks,
bq.
bq. Prasad
bq.
bq.
> Support RFC 3164 and 5424 syslog format timestamp parsing
> ---------------------------------------------------------
>
> Key: FLUME-1126
> URL: https://issues.apache.org/jira/browse/FLUME-1126
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.2.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: v1.2.0
>
> Attachments: FLUME-1126-9.patch
>
>
> Support RFC 3164 and 5424 syslog format timestamp parsing for syslog source
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1126) Support RFC 3164 and 5424 syslog
format timestamp parsing
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257949#comment-13257949 ]
jiraposter@reviews.apache.org commented on FLUME-1126:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4809/#review7053
-----------------------------------------------------------
Prasad, I get the following error. Patch needs a rebase against trunk?
$ patch -p0 < FLUME-1126-5.patch
patching file flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java
patching file flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java
patch: **** malformed patch at line 315: diff --git flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java
- Mike
On 2012-04-19 23:01:28, Prasad Mujumdar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4809/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-19 23:01:28)
bq.
bq.
bq. Review request for Flume, Arvind Prabhakar and Mike Percy.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Support for timestamp and hostname parsing.
bq.
bq.
bq. This addresses bug FLUME-1126.
bq. https://issues.apache.org/jira/browse/FLUME-1126
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java 3a7c486
bq. flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 8b1f7c5
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java b0485b1
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 732cce5
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java 653f5eb
bq.
bq. Diff: https://reviews.apache.org/r/4809/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated syslog tests to cover timestamp and hostname handling.
bq. Manually tested using syslog4j
bq.
bq.
bq. Thanks,
bq.
bq. Prasad
bq.
bq.
> Support RFC 3164 and 5424 syslog format timestamp parsing
> ---------------------------------------------------------
>
> Key: FLUME-1126
> URL: https://issues.apache.org/jira/browse/FLUME-1126
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.2.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: v1.2.0
>
>
> Support RFC 3164 and 5424 syslog format timestamp parsing for syslog source
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1126) Support RFC 3164 and 5424 syslog
format timestamp parsing
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261244#comment-13261244 ]
jiraposter@reviews.apache.org commented on FLUME-1126:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4809/#review7200
-----------------------------------------------------------
Thanks for the patch Prasad. I have a few nits/requests below, along with a refactoring request noted below.
flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java
<https://reviews.apache.org/r/4809/#comment15902>
While you are incorporating the feedback, it will be great if you could change this class name to be convention compliant (SyslogTcpHandler instead of syslogTcpHandler).
flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java
<https://reviews.apache.org/r/4809/#comment15901>
Instead of doing this, please add a constructor that takes these flags as arguments and sets it up on a newly created syslogUtils object.
flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java
<https://reviews.apache.org/r/4809/#comment15903>
instead it will be something like:
handler = new SyslogTcpHandler(eventSiz,e hasVersion, useRFC5424);
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java
<https://reviews.apache.org/r/4809/#comment15898>
typo: Boolean instead of boolean
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java
<https://reviews.apache.org/r/4809/#comment15904>
Class name SyslogUdpHandler please.
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java
<https://reviews.apache.org/r/4809/#comment15896>
Prefer to use the constructor that has event size, udp flag and rfc5424 flag.
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
<https://reviews.apache.org/r/4809/#comment15905>
Suggest removing this constructor and the other one that takes the (isUdp, useRFC5424) arguments.
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
<https://reviews.apache.org/r/4809/#comment15897>
Suggest not modifying the constructor argument list for consistency. Instead have the caller use the setter method as is being used for hasVersion flag.
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
<https://reviews.apache.org/r/4809/#comment15907>
This adhoc parsing has become significantly complex and hard to follow. It will be better to instead have a standard solution that parses the event body into subcomponents as necessary. For example it could be done by:
* using a table driven parser based on standard grammar
* using an externally specified format to parse the body of the event
* using a externally specified regular expression that parses the body of the event.
Minimally, I request that this part be refactored so that the parsing of the body is done in the buildEvent() method by a secondary routine instead.
This will ensure that the current implementation continues to work and the secondary parsing can be done defensively and thus default to old semantics if it is unable to parse the expected fields correctly.
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
<https://reviews.apache.org/r/4809/#comment15900>
Please remove this setter and instead force the use of the constructor instead.
- Arvind
On 2012-04-20 03:19:50, Prasad Mujumdar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4809/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-20 03:19:50)
bq.
bq.
bq. Review request for Flume, Arvind Prabhakar and Mike Percy.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Support for timestamp and hostname parsing.
bq.
bq.
bq. This addresses bug FLUME-1126.
bq. https://issues.apache.org/jira/browse/FLUME-1126
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java b0485b1
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 732cce5
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java 653f5eb
bq. flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java 3a7c486
bq. flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 8b1f7c5
bq.
bq. Diff: https://reviews.apache.org/r/4809/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated syslog tests to cover timestamp and hostname handling.
bq. Manually tested using syslog4j
bq.
bq.
bq. Thanks,
bq.
bq. Prasad
bq.
bq.
> Support RFC 3164 and 5424 syslog format timestamp parsing
> ---------------------------------------------------------
>
> Key: FLUME-1126
> URL: https://issues.apache.org/jira/browse/FLUME-1126
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.2.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: v1.2.0
>
>
> Support RFC 3164 and 5424 syslog format timestamp parsing for syslog source
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1126) Support RFC 3164 and 5424 syslog
format timestamp parsing
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263771#comment-13263771 ]
jiraposter@reviews.apache.org commented on FLUME-1126:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4809/#review7304
-----------------------------------------------------------
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
<https://reviews.apache.org/r/4809/#comment16129>
Its not used anymore, removed.
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
<https://reviews.apache.org/r/4809/#comment16130>
Done
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
<https://reviews.apache.org/r/4809/#comment16131>
Done
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
<https://reviews.apache.org/r/4809/#comment16132>
Done
flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java
<https://reviews.apache.org/r/4809/#comment16133>
Done
- Prasad
On 2012-04-27 14:58:21, Prasad Mujumdar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4809/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-27 14:58:21)
bq.
bq.
bq. Review request for Flume, Arvind Prabhakar and Mike Percy.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Support for timestamp and hostname parsing.
bq.
bq.
bq. This addresses bug FLUME-1126.
bq. https://issues.apache.org/jira/browse/FLUME-1126
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java b0485b1
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 732cce5
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java 653f5eb
bq. flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 8b1f7c5
bq.
bq. Diff: https://reviews.apache.org/r/4809/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated syslog tests to cover timestamp and hostname handling.
bq. Manually tested using syslog4j
bq.
bq.
bq. Thanks,
bq.
bq. Prasad
bq.
bq.
> Support RFC 3164 and 5424 syslog format timestamp parsing
> ---------------------------------------------------------
>
> Key: FLUME-1126
> URL: https://issues.apache.org/jira/browse/FLUME-1126
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.2.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: v1.2.0
>
>
> Support RFC 3164 and 5424 syslog format timestamp parsing for syslog source
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1126) Support RFC 3164 and 5424 syslog
format timestamp parsing
Posted by "Prasad Mujumdar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Mujumdar updated FLUME-1126:
-----------------------------------
Status: Patch Available (was: Open)
> Support RFC 3164 and 5424 syslog format timestamp parsing
> ---------------------------------------------------------
>
> Key: FLUME-1126
> URL: https://issues.apache.org/jira/browse/FLUME-1126
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.2.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: v1.2.0
>
> Attachments: FLUME-1126-9.patch
>
>
> Support RFC 3164 and 5424 syslog format timestamp parsing for syslog source
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1126) Support RFC 3164 and 5424 syslog
format timestamp parsing
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258589#comment-13258589 ]
jiraposter@reviews.apache.org commented on FLUME-1126:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4809/#review7093
-----------------------------------------------------------
Nice work Prasad, looks good overall. I have a couple of nits / questions inline.
Also, we should file another JIRA to support the RFC5424 timestamp format that supports fractional seconds, i.e. 2003-10-11T22:14:15.003Z and 2003-08-24T05:14:15.000003-07:00. While we would need to round microsecond times to the nearest millisecond since our base format is Java milliseconds since the epoch, today we treat these example timestamp strings as invalid.
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
<https://reviews.apache.org/r/4809/#comment15702>
This variable is not ever read.
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
<https://reviews.apache.org/r/4809/#comment15703>
Not sure what's going on here. Why are we checking for a dash? And what does startedTimeStamp mean? I don't think it means we have started parsing the timestamp.
- Mike
On 2012-04-20 03:19:50, Prasad Mujumdar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4809/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-20 03:19:50)
bq.
bq.
bq. Review request for Flume, Arvind Prabhakar and Mike Percy.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Support for timestamp and hostname parsing.
bq.
bq.
bq. This addresses bug FLUME-1126.
bq. https://issues.apache.org/jira/browse/FLUME-1126
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java b0485b1
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 732cce5
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java 653f5eb
bq. flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java 3a7c486
bq. flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 8b1f7c5
bq.
bq. Diff: https://reviews.apache.org/r/4809/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated syslog tests to cover timestamp and hostname handling.
bq. Manually tested using syslog4j
bq.
bq.
bq. Thanks,
bq.
bq. Prasad
bq.
bq.
> Support RFC 3164 and 5424 syslog format timestamp parsing
> ---------------------------------------------------------
>
> Key: FLUME-1126
> URL: https://issues.apache.org/jira/browse/FLUME-1126
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.2.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: v1.2.0
>
>
> Support RFC 3164 and 5424 syslog format timestamp parsing for syslog source
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1126) Support RFC 3164 and 5424 syslog
format timestamp parsing
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263762#comment-13263762 ]
jiraposter@reviews.apache.org commented on FLUME-1126:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4809/#review7303
-----------------------------------------------------------
Ship it!
+1
Changes look good Prasad. Some nits noted below. Once you are done with the revision, please update the patch on the Jira.
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
<https://reviews.apache.org/r/4809/#comment16126>
convention: rename to messageFormats instead of using underscore.
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
<https://reviews.apache.org/r/4809/#comment16125>
convention: please use class name with CamelCase (SyslogFormater)
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
<https://reviews.apache.org/r/4809/#comment16127>
nit: please rename it to initHeaderFormats() instead.
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
<https://reviews.apache.org/r/4809/#comment16124>
nit: please remove extraneous whitespace.
flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java
<https://reviews.apache.org/r/4809/#comment16128>
nit:trailing whitespace.
- Arvind
On 2012-04-27 14:58:21, Prasad Mujumdar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4809/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-27 14:58:21)
bq.
bq.
bq. Review request for Flume, Arvind Prabhakar and Mike Percy.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Support for timestamp and hostname parsing.
bq.
bq.
bq. This addresses bug FLUME-1126.
bq. https://issues.apache.org/jira/browse/FLUME-1126
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java b0485b1
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 732cce5
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java 653f5eb
bq. flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 8b1f7c5
bq.
bq. Diff: https://reviews.apache.org/r/4809/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated syslog tests to cover timestamp and hostname handling.
bq. Manually tested using syslog4j
bq.
bq.
bq. Thanks,
bq.
bq. Prasad
bq.
bq.
> Support RFC 3164 and 5424 syslog format timestamp parsing
> ---------------------------------------------------------
>
> Key: FLUME-1126
> URL: https://issues.apache.org/jira/browse/FLUME-1126
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.2.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: v1.2.0
>
>
> Support RFC 3164 and 5424 syslog format timestamp parsing for syslog source
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1126) Support RFC 3164 and 5424 syslog
format timestamp parsing
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257612#comment-13257612 ]
jiraposter@reviews.apache.org commented on FLUME-1126:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4809/
-----------------------------------------------------------
Review request for Flume, Arvind Prabhakar and Mike Percy.
Summary
-------
Support for timestamp and hostname parsing.
This addresses bug FLUME-1126.
https://issues.apache.org/jira/browse/FLUME-1126
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 732cce5
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java 653f5eb
flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java 3a7c486
flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 8b1f7c5
Diff: https://reviews.apache.org/r/4809/diff
Testing
-------
Updated syslog tests to cover timestamp and hostname handling.
Manually tested using syslog4j
Thanks,
Prasad
> Support RFC 3164 and 5424 syslog format timestamp parsing
> ---------------------------------------------------------
>
> Key: FLUME-1126
> URL: https://issues.apache.org/jira/browse/FLUME-1126
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.2.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: v1.2.0
>
>
> Support RFC 3164 and 5424 syslog format timestamp parsing for syslog source
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1126) Support RFC 3164 and 5424 syslog
format timestamp parsing
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258602#comment-13258602 ]
jiraposter@reviews.apache.org commented on FLUME-1126:
------------------------------------------------------
bq. On 2012-04-20 21:05:23, Mike Percy wrote:
bq. > Nice work Prasad, looks good overall. I have a couple of nits / questions inline.
bq. >
bq. > Also, we should file another JIRA to support the RFC5424 timestamp format that supports fractional seconds, i.e. 2003-10-11T22:14:15.003Z and 2003-08-24T05:14:15.000003-07:00. While we would need to round microsecond times to the nearest millisecond since our base format is Java milliseconds since the epoch, today we treat these example timestamp strings as invalid.
Create FLUME-1138 to track the millisecond format.
bq. On 2012-04-20 21:05:23, Mike Percy wrote:
bq. > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java, line 60
bq. > <https://reviews.apache.org/r/4809/diff/4/?file=103439#file103439line60>
bq. >
bq. > This variable is not ever read.
right, that logic was changed and it's no longer need. will remove it.
bq. On 2012-04-20 21:05:23, Mike Percy wrote:
bq. > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java, line 267
bq. > <https://reviews.apache.org/r/4809/diff/4/?file=103439#file103439line267>
bq. >
bq. > Not sure what's going on here. Why are we checking for a dash? And what does startedTimeStamp mean? I don't think it means we have started parsing the timestamp.
The RFC5424 allows a 'null' timestamp which contains a single '-'
The code is checking for the dash as first character. I guess that variable name is confusing, will change that.
- Prasad
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4809/#review7093
-----------------------------------------------------------
On 2012-04-20 03:19:50, Prasad Mujumdar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4809/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-20 03:19:50)
bq.
bq.
bq. Review request for Flume, Arvind Prabhakar and Mike Percy.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Support for timestamp and hostname parsing.
bq.
bq.
bq. This addresses bug FLUME-1126.
bq. https://issues.apache.org/jira/browse/FLUME-1126
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java b0485b1
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 732cce5
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java 653f5eb
bq. flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java 3a7c486
bq. flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 8b1f7c5
bq.
bq. Diff: https://reviews.apache.org/r/4809/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated syslog tests to cover timestamp and hostname handling.
bq. Manually tested using syslog4j
bq.
bq.
bq. Thanks,
bq.
bq. Prasad
bq.
bq.
> Support RFC 3164 and 5424 syslog format timestamp parsing
> ---------------------------------------------------------
>
> Key: FLUME-1126
> URL: https://issues.apache.org/jira/browse/FLUME-1126
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.2.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: v1.2.0
>
>
> Support RFC 3164 and 5424 syslog format timestamp parsing for syslog source
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1126) Support RFC 3164 and 5424 syslog
format timestamp parsing
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257891#comment-13257891 ]
jiraposter@reviews.apache.org commented on FLUME-1126:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4809/
-----------------------------------------------------------
(Updated 2012-04-19 23:01:28.382738)
Review request for Flume, Arvind Prabhakar and Mike Percy.
Changes
-------
Correct version string handling for RFC3164
Fix facility calculation
additional tests
Summary
-------
Support for timestamp and hostname parsing.
This addresses bug FLUME-1126.
https://issues.apache.org/jira/browse/FLUME-1126
Diffs (updated)
-----
flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java 3a7c486
flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 8b1f7c5
flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java b0485b1
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 732cce5
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java 653f5eb
Diff: https://reviews.apache.org/r/4809/diff
Testing
-------
Updated syslog tests to cover timestamp and hostname handling.
Manually tested using syslog4j
Thanks,
Prasad
> Support RFC 3164 and 5424 syslog format timestamp parsing
> ---------------------------------------------------------
>
> Key: FLUME-1126
> URL: https://issues.apache.org/jira/browse/FLUME-1126
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.2.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: v1.2.0
>
>
> Support RFC 3164 and 5424 syslog format timestamp parsing for syslog source
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1126) Support RFC 3164 and 5424 syslog
format timestamp parsing
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264086#comment-13264086 ]
jiraposter@reviews.apache.org commented on FLUME-1126:
------------------------------------------------------
bq. On 2012-04-27 21:27:56, Mike Percy wrote:
bq. > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java, line 52
bq. > <https://reviews.apache.org/r/4809/diff/5/?file=104882#file104882line52>
bq. >
bq. > The RFC5424 version field should be a digit followed by a space. So I think this pattern should be: "(?:\\d\\s)?"; i.e. no [] character class around in. Worth adding a unit test w/ the example messages from RFC5424 to be sure it's compliant.
Actually, I just checked and it works as-is. So, nevermind this comment :)
bq. On 2012-04-27 21:27:56, Mike Percy wrote:
bq. > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java, line 241
bq. > <https://reviews.apache.org/r/4809/diff/5/?file=104882#file104882line241>
bq. >
bq. > Why would the Scanner be closed? Shouldn't this exception be logged or re-thrown?
Looks like it's not a closed Scanner but it will throw if match() is called when there are no matches. So, please disregard this too.
- Mike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4809/#review7321
-----------------------------------------------------------
On 2012-04-27 14:58:21, Prasad Mujumdar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4809/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-27 14:58:21)
bq.
bq.
bq. Review request for Flume, Arvind Prabhakar and Mike Percy.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Support for timestamp and hostname parsing.
bq.
bq.
bq. This addresses bug FLUME-1126.
bq. https://issues.apache.org/jira/browse/FLUME-1126
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java b0485b1
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 732cce5
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java 653f5eb
bq. flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 8b1f7c5
bq.
bq. Diff: https://reviews.apache.org/r/4809/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated syslog tests to cover timestamp and hostname handling.
bq. Manually tested using syslog4j
bq.
bq.
bq. Thanks,
bq.
bq. Prasad
bq.
bq.
> Support RFC 3164 and 5424 syslog format timestamp parsing
> ---------------------------------------------------------
>
> Key: FLUME-1126
> URL: https://issues.apache.org/jira/browse/FLUME-1126
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.2.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: v1.2.0
>
> Attachments: FLUME-1126-9.patch
>
>
> Support RFC 3164 and 5424 syslog format timestamp parsing for syslog source
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1126) Support RFC 3164 and 5424 syslog
format timestamp parsing
Posted by "Prasad Mujumdar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Mujumdar updated FLUME-1126:
-----------------------------------
Attachment: FLUME-1126-9.patch
> Support RFC 3164 and 5424 syslog format timestamp parsing
> ---------------------------------------------------------
>
> Key: FLUME-1126
> URL: https://issues.apache.org/jira/browse/FLUME-1126
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.2.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: v1.2.0
>
> Attachments: FLUME-1126-9.patch
>
>
> Support RFC 3164 and 5424 syslog format timestamp parsing for syslog source
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira