You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2019/11/22 16:10:29 UTC
[GitHub] [qpid-proton] astitcher commented on issue #209: PROTON-2138:
properly parse the remote terminus properties
astitcher commented on issue #209: PROTON-2138: properly parse the remote terminus properties
URL: https://github.com/apache/qpid-proton/pull/209#issuecomment-557593244
I don't currently have the protocol knowledge to fully review this change.
I'd feel a lot more comfortable with it if there was a a test added that would fail with the current code and succeed with this change. (Probably in the python tests)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org