[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6720: [NIFI-10876] Made changes to convert from JUnit 4 to JUnit 5

[GitBox <gi...@apache.org>]

exceptionfactory commented on code in PR #6720:
URL: https://github.com/apache/nifi/pull/6720#discussion_r1032704792


##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/test/java/org/apache/nifi/util/CharacterFilterUtilsTest.java:
##########
@@ -27,7 +27,7 @@ public void filterInvalidCharacters() throws Exception {
         final String filtered = CharacterFilterUtils.filterInvalidXmlCharacters(text);
 
         final String expected = "This is an example with characters that need to be filtered  in it. ";
-        Assert.assertEquals(expected, filtered);
+        Assertions.assertEquals(expected, filtered);

Review Comment:
   This is a good opportunity to replace class references with static imports:
   ```suggestion
           assertEquals(expected, filtered);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org