You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/01/05 19:07:08 UTC

Review Request 55222: Avoided unnecessary copies in mesos.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55222/
-----------------------------------------------------------

Review request for mesos and Michael Park.


Repository: mesos


Description
-------

Spotted with clang-tidy.


Diffs
-----

  src/master/master.cpp 11c34a048586d30c6ac67be8638ed8fa81cc3f1f 
  src/slave/containerizer/mesos/containerizer.cpp d9d5619e45ae1199fc91878f17a33b5647f48305 
  src/slave/containerizer/mesos/provisioner/appc/cache.hpp 1e10dc604b29e418beacad6475910dcf7f8899c0 
  src/slave/containerizer/mesos/provisioner/appc/cache.cpp 20a7030d864bc463322140937b7ae3dbef7d77a0 

Diff: https://reviews.apache.org/r/55222/diff/


Testing
-------

`make check` on OSX and Linux, plus internal CI.


Thanks,

Neil Conway

Re: Review Request 55222: Avoided unnecessary copies in mesos.

Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55222/#review160987
-----------------------------------------------------------


Ship it!




Ship It!

- Michael Park


On Jan. 5, 2017, 12:05 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55222/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2017, 12:05 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Spotted with clang-tidy.
> 
> 
> Diffs
> -----
> 
>   src/common/http.cpp 05215ca66c04e4f1c8bcb0e5bf671a8a08ca0548 
>   src/examples/long_lived_framework.cpp 03c26d921fba670655f3563009ecd3bed2e828f1 
>   src/master/contender/contender.cpp 3debf4730830eb48a97b404c14e34adb7e4c8f3d 
>   src/master/master.cpp 11c34a048586d30c6ac67be8638ed8fa81cc3f1f 
>   src/slave/containerizer/mesos/containerizer.cpp d9d5619e45ae1199fc91878f17a33b5647f48305 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 276b9003aa2671b9ca819e44fb1cd60ae9dff167 
>   src/slave/containerizer/mesos/provisioner/appc/cache.hpp 1e10dc604b29e418beacad6475910dcf7f8899c0 
>   src/slave/containerizer/mesos/provisioner/appc/cache.cpp 20a7030d864bc463322140937b7ae3dbef7d77a0 
>   src/tests/containerizer/docker_containerizer_tests.cpp 4e3b67bbb989f9084dfdf4970839956dcb0caa0e 
>   src/tests/environment.cpp a683d8c221635f81906abbead1e01d2469850d93 
>   src/tests/mesos.hpp fa965150ae3e31b4d74dac57148a197402fd551e 
> 
> Diff: https://reviews.apache.org/r/55222/diff/
> 
> 
> Testing
> -------
> 
> `make check` on OSX and Linux, plus internal CI.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 55222: Avoided unnecessary copies in mesos.

Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55222/
-----------------------------------------------------------

(Updated Jan. 5, 2017, 8:05 p.m.)


Review request for mesos and Michael Park.


Changes
-------

More fixes.


Repository: mesos


Description
-------

Spotted with clang-tidy.


Diffs (updated)
-----

  src/common/http.cpp 05215ca66c04e4f1c8bcb0e5bf671a8a08ca0548 
  src/examples/long_lived_framework.cpp 03c26d921fba670655f3563009ecd3bed2e828f1 
  src/master/contender/contender.cpp 3debf4730830eb48a97b404c14e34adb7e4c8f3d 
  src/master/master.cpp 11c34a048586d30c6ac67be8638ed8fa81cc3f1f 
  src/slave/containerizer/mesos/containerizer.cpp d9d5619e45ae1199fc91878f17a33b5647f48305 
  src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 276b9003aa2671b9ca819e44fb1cd60ae9dff167 
  src/slave/containerizer/mesos/provisioner/appc/cache.hpp 1e10dc604b29e418beacad6475910dcf7f8899c0 
  src/slave/containerizer/mesos/provisioner/appc/cache.cpp 20a7030d864bc463322140937b7ae3dbef7d77a0 
  src/tests/containerizer/docker_containerizer_tests.cpp 4e3b67bbb989f9084dfdf4970839956dcb0caa0e 
  src/tests/environment.cpp a683d8c221635f81906abbead1e01d2469850d93 
  src/tests/mesos.hpp fa965150ae3e31b4d74dac57148a197402fd551e 

Diff: https://reviews.apache.org/r/55222/diff/


Testing
-------

`make check` on OSX and Linux, plus internal CI.


Thanks,

Neil Conway